Kevin Murphy

Results 26 comments of Kevin Murphy

hm weird, I'll hopefully have a minute to look into this later this week before school starts

@MaathavanJkr in general, using text in favicons/logos is not always the best idea, since they tend to be viewed at tiny resolution (below is a 20x20 render). Thanks for your...

> Is merging all the package version bumps safe, @keggsmurph21? (See open PRs) > > I worry that some things have changed major version number, e.g. ejs from version 2...

Oops, I didn't mean to close the whole issue ... but https://github.com/jonorthwash/ud-annotatrix/commit/a3828a4796f3f67e0517e5b8ccdc41b0b901832c should fix this part: > Another bug: if you initialize the tree without the multiword token, click the...

> Oh but this is interesting: if I click the third word and enter "c" to merge left, it deletes the first word. So the merging functionality must be buggy....

Yeah, this is a bit of an architectural problem. Currently, we just serialize the entire treebank and try to load it on the client here: https://github.com/jonorthwash/ud-annotatrix/blob/f6865f17487daea9b0d296035d32a6b85cc5ea41/client/server.js#L122 via https://github.com/jonorthwash/ud-annotatrix/blob/f6865f17487daea9b0d296035d32a6b85cc5ea41/server/routes.js#L125-L131 This is...

FWIW, I think we could improve here, but it's a bit tough to make these large changes with confidence. I think maybe if we added some static type information it...

see issue #97

Hm, there is a multiple-space-to-tab conversion function built into `notatrix`, so I would expect this to work. I'm not immediately sure why it wouldn't. Also, when I copy/paste from Vim,...

> > Hm, there is a multiple-space-to-tab conversion function built into `notatrix`, so I would expect this to work. I'm not immediately sure why it wouldn't. > > Could you...