readme-md-generator icon indicating copy to clipboard operation
readme-md-generator copied to clipboard

Manage multiple authors

Open louckousse opened this issue 5 years ago • 4 comments

Fix #146

louckousse avatar Oct 04 '19 21:10 louckousse

Codecov Report

Merging #147 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #147   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     24           
  Lines         197    197           
  Branches       21     21           
=====================================
  Hits          197    197
Impacted Files Coverage Δ
src/questions/author-twitter.js 100% <ø> (ø) :arrow_up:
src/questions/author-github.js 100% <ø> (ø) :arrow_up:
src/questions/author-name.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32af6a2...797aa4b. Read the comment docs.

codecov[bot] avatar Oct 05 '19 09:10 codecov[bot]

And if there are not the same number of authors names and github names or twitter ?

Maybe, if there are multiple authors, ask github or twitter for each ?

patou avatar Oct 09 '19 15:10 patou

person1,,person3 TADAM problem solved. The way questions are asked it's too complicated for me to loop on these.

louckousse avatar Oct 09 '19 20:10 louckousse

Hey @louckousse (sorry for the delay) thanks for your work 💪 I'll try to improve the rendering part by moving the code from ejs to node (using inquirer transformer function), it will allow us to make this code testable 👍

kefranabg avatar Oct 24 '19 14:10 kefranabg