keep icon indicating copy to clipboard operation
keep copied to clipboard

fix: Allow filtering incidents by is_visible status

Open subha0319 opened this issue 3 months ago • 2 comments

Removes the hardcoded is_visible == True filter from the base incident query when an explicit is_visible filter is provided via CEL. This allows querying for non-visible incidents (e.g., is_visible == false).

Fixes keephq#5376

Closes #

📑 Description

✅ Checks

  • [x] My pull request adheres to the code style of this project
  • [ ] My code requires changes to the documentation
  • [ ] I have updated the documentation as required
  • [x] All the tests have passed

ℹ Additional Information

subha0319 avatar Oct 20 '25 18:10 subha0319

@subha0319 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 20 '25 18:10 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 20 '25 18:10 CLAassistant

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
keep Ready Ready Preview Comment Nov 16, 2025 2:02pm

vercel[bot] avatar Nov 16 '25 13:11 vercel[bot]

💪 Fantastic work @subha0319! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

github-actions[bot] avatar Nov 16 '25 14:11 github-actions[bot]

Codecov Report

:x: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 30.55%. Comparing base (97c263a) to head (576f054). :warning: Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/incidents.py 0.00% 6 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5377       +/-   ##
===========================================
- Coverage   46.39%   30.55%   -15.85%     
===========================================
  Files         176      101       -75     
  Lines       18412    11669     -6743     
===========================================
- Hits         8543     3565     -4978     
+ Misses       9869     8104     -1765     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 16 '25 14:11 codecov[bot]