keep icon indicating copy to clipboard operation
keep copied to clipboard

fix: Incident field cant be queried

Open skynetigor opened this issue 7 months ago • 2 comments

Closes #4432

📑 Description

  • Add mechanism that will detect data type of being filtered field and perform conversion depending on dealect
  • Add UUID data type support by SQLite, MySQL, PostgreSQL in CEL-to-SQL translator
  • Make id (alert id) and incident.id be UUID during alert queries
  • Make id (incident id) be UUID during incident queries
  • Support dashed or HEX types of UUID in CEL

✅ Checks

  • [ ] My pull request adheres to the code style of this project
  • [ ] My code requires changes to the documentation
  • [ ] I have updated the documentation as required
  • [ ] All the tests have passed

ℹ Additional Information

skynetigor avatar Apr 27 '25 09:04 skynetigor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2025 11:11am

vercel[bot] avatar Apr 27 '25 09:04 vercel[bot]

Codecov Report

Attention: Patch coverage is 28.57143% with 30 lines in your changes missing coverage. Please review.

Project coverage is 30.91%. Comparing base (d39afd3) to head (31a0543). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/cel_to_sql/sql_providers/base.py 20.00% 8 Missing :warning:
keep/api/core/cel_to_sql/sql_providers/sqlite.py 27.27% 8 Missing :warning:
keep/api/core/cel_to_sql/sql_providers/mysql.py 22.22% 7 Missing :warning:
...ep/api/core/cel_to_sql/sql_providers/postgresql.py 25.00% 6 Missing :warning:
keep/api/core/cel_to_sql/properties_mapper.py 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4620       +/-   ##
===========================================
- Coverage   46.77%   30.91%   -15.86%     
===========================================
  Files         164       93       -71     
  Lines       16841    10629     -6212     
===========================================
- Hits         7877     3286     -4591     
+ Misses       8964     7343     -1621     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 27 '25 10:04 codecov[bot]