fix: workflow provisioning/deprovisioning
Closes #4603
📑 Description
This PR fix provisioning and deprovisioning logic of workflows
@EnotShow is attempting to deploy a commit to the KeepHQ Team on Vercel.
A member of the Team first needs to authorize it.
Codecov Report
Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
Project coverage is 31.00%. Comparing base (
6e71143) to head (a9e8ee0). Report is 42 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| keep/workflowmanager/workflowstore.py | 0.00% | 8 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #4607 +/- ##
==========================================
+ Coverage 30.95% 31.00% +0.04%
==========================================
Files 93 93
Lines 10534 10593 +59
==========================================
+ Hits 3261 3284 +23
- Misses 7273 7309 +36
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@talboren Need review
Hi @shahargl and @talboren, could you please help me and @EnotShow review this PR? It aims to improve our provisioning workflows. Currently, we cannot delete a workflow once it has been provisioned. Additionally, in the recent versions of Keep, each time the backend service restarts, it re-provisions the workflow, resulting in a duplicate workflow.
Also @EnotShow, can you add more tests in order to improve code coverage.