keep
keep copied to clipboard
Cloudwatch provider - make the subscription URL configurable
Is your feature request related to a problem? Please describe. The Cloudwatch provider automatically tries to create the subscription to your backend URL. It might not be a single hop on a prod environment.
This also causes an issue when someone tries to use the provider from the vanilla helm charts. The backend is on http, but the SNS subscription wants to subscribe on https resulting in:
"errorCode": "InvalidParameterException", "errorMessage": "Invalid parameter: Endpoint must match the specified protocol",
Describe the solution you'd like Maybe provide an option where to subscribe, instead of generating the URL.
Hi! I'd be glad to contribute to your project and take this issue on me. Are there any additional requirements and notes I need to take into account except for described above and those in CONTRIBUTING.md ?
Hey @Ilia1099, welcome!
nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?
Hey @Ilia1099, welcome!
nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?
Sure, Iād appreciate that!
Assigned
Hey @Ilia1099, welcome!
nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?
is it possible to join your slack?
Hey @Ilia1099, welcome! nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?
is it possible to join your slack?
You are more then welcome! This is the link :)
/bounty 20
š $20 bounty ā¢ Keep (YC W23)
Steps to solve:
-
Start working: Comment
/attempt #395
with your implementation plan -
Submit work: Create a pull request including
/claim #395
in the PR body to claim the bounty - Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts
Thank you for contributing to keephq/keep!
Add a bounty ā¢ Share on socials
Attempt | Started (GMT+0) | Solution |
---|---|---|
š“ @ezhil56x | Jun 6, 2024, 10:25:13 AM | WIP |
š“ @unworld11 | Jun 24, 2024, 9:48:35 AM | WIP |
š” @Ayush-Vish | Jul 13, 2024, 3:56:01 AM | WIP |
š” @lata-11 | Jul 13, 2024, 3:53:00 PM | WIP |
š¢ @HemanthGangula | Jul 21, 2024, 4:58:47 AM | WIP |
Can I get this assigned? /attempt #395
Algora profile | Completed bounties | Tech | Active attempts | Options |
---|---|---|---|---|
@ezhil56x | Ā Ā Ā 6 keephq bounties + 25 bounties from 10 projects |
JavaScript, TypeScript, Java & more |
ļ¹732 |
Cancel attempt |
@Ilia1099 Are you still working on this or can I take up? Thanks!
@Ilia1099 Are you still working on this or can I take up? Thanks!
Yes, I'm working, planing to make pull request this Saturday.
@ezhil56x: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then š
Created pull requests for my solution
The bounty is up for grabs! Everyone is welcome to /attempt #395
š
/attempt #395
- Modify the Provider Configuration Add a new configuration option for the subscription URL in the provider's configuration schema
- Update the Provider Logic Use the new configuration option when creating the subscription. If the option is not set, fall back to the existing behavior
- Update the Helm Charts Add a new value for the subscription URL in the Helm chart values file and template
Options
@unworld11: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then š
The bounty is up for grabs! Everyone is welcome to /attempt #395
š
@unworld11 Are you still working on this issue.
no i am unassigning myself.
[!NOTE] The user @Ayush-Vish is already attempting to complete issue #395 and claim the bounty. We recommend checking in on @Ayush-Vish's progress, and potentially collaborating, before starting a new solution.
@Ayush-Vish: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then š
@lata-11: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then š
/attempt #395
Implementation Plan
-
Update Configuration Schema:
- Add a new optional field
subscription_url
to the configuration schema.
- Add a new optional field
-
Modify Subscription Logic:
- Update the logic to use the provided
subscription_url
if available, otherwise generate the default URL.
- Update the logic to use the provided
-
Update Documentation:
- Reflect the new
subscription_url
configuration option in the documentation.
- Reflect the new