keep icon indicating copy to clipboard operation
keep copied to clipboard

Cloudwatch provider - make the subscription URL configurable

Open PeterSzegedi opened this issue 1 year ago ā€¢ 25 comments

Is your feature request related to a problem? Please describe. The Cloudwatch provider automatically tries to create the subscription to your backend URL. It might not be a single hop on a prod environment.

This also causes an issue when someone tries to use the provider from the vanilla helm charts. The backend is on http, but the SNS subscription wants to subscribe on https resulting in:

"errorCode": "InvalidParameterException", "errorMessage": "Invalid parameter: Endpoint must match the specified protocol",

Describe the solution you'd like Maybe provide an option where to subscribe, instead of generating the URL.

PeterSzegedi avatar Oct 09 '23 15:10 PeterSzegedi

Hi! I'd be glad to contribute to your project and take this issue on me. Are there any additional requirements and notes I need to take into account except for described above and those in CONTRIBUTING.md ?

Ilia1099 avatar May 18 '24 17:05 Ilia1099

Hey @Ilia1099, welcome!

nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?

shahargl avatar May 18 '24 19:05 shahargl

Hey @Ilia1099, welcome!

nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?

Sure, Iā€™d appreciate that!

Ilia1099 avatar May 18 '24 20:05 Ilia1099

Assigned

shahargl avatar May 19 '24 04:05 shahargl

Hey @Ilia1099, welcome!

nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?

is it possible to join your slack?

Ilia1099 avatar May 19 '24 19:05 Ilia1099

Hey @Ilia1099, welcome! nope, we usually suggest contributors to join our Slack. The reason is that in the first issues there are many questions about how to do things and it easier to help there. Do you want me to assign you the ticket?

is it possible to join your slack?

You are more then welcome! This is the link :)

talboren avatar May 19 '24 19:05 talboren

/bounty 20

Matvey-Kuk avatar Jun 06 '24 10:06 Matvey-Kuk

šŸ’Ž $20 bounty ā€¢ Keep (YC W23)

Steps to solve:

  1. Start working: Comment /attempt #395 with your implementation plan
  2. Submit work: Create a pull request including /claim #395 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to keephq/keep!

Add a bounty ā€¢ Share on socials

Attempt Started (GMT+0) Solution
šŸ”“ @ezhil56x Jun 6, 2024, 10:25:13 AM WIP
šŸ”“ @unworld11 Jun 24, 2024, 9:48:35 AM WIP
šŸŸ” @Ayush-Vish Jul 13, 2024, 3:56:01 AM WIP
šŸŸ” @lata-11 Jul 13, 2024, 3:53:00 PM WIP
šŸŸ¢ @HemanthGangula Jul 21, 2024, 4:58:47 AM WIP

algora-pbc[bot] avatar Jun 06 '24 10:06 algora-pbc[bot]

Can I get this assigned? /attempt #395

Algora profile Completed bounties Tech Active attempts Options
@ezhil56x Ā Ā Ā 6 keephq bounties
+ 25 bounties from 10 projects
JavaScript, TypeScript,
Java & more
ļ¹Ÿ732
Cancel attempt

ezhil56x avatar Jun 06 '24 10:06 ezhil56x

@Ilia1099 Are you still working on this or can I take up? Thanks!

ezhil56x avatar Jun 06 '24 11:06 ezhil56x

@Ilia1099 Are you still working on this or can I take up? Thanks!

Yes, I'm working, planing to make pull request this Saturday.

Ilia1099 avatar Jun 06 '24 12:06 Ilia1099

@ezhil56x: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then šŸ™

algora-pbc[bot] avatar Jun 09 '24 10:06 algora-pbc[bot]

Created pull requests for my solution

Ilia1099 avatar Jun 09 '24 19:06 Ilia1099

The bounty is up for grabs! Everyone is welcome to /attempt #395 šŸ™Œ

algora-pbc[bot] avatar Jun 13 '24 10:06 algora-pbc[bot]

/attempt #395

  1. Modify the Provider Configuration Add a new configuration option for the subscription URL in the provider's configuration schema
  2. Update the Provider Logic Use the new configuration option when creating the subscription. If the option is not set, fall back to the existing behavior
  3. Update the Helm Charts Add a new value for the subscription URL in the Helm chart values file and template
Options

unworld11 avatar Jun 24 '24 09:06 unworld11

@unworld11: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then šŸ™

algora-pbc[bot] avatar Jun 27 '24 09:06 algora-pbc[bot]

The bounty is up for grabs! Everyone is welcome to /attempt #395 šŸ™Œ

algora-pbc[bot] avatar Jul 01 '24 09:07 algora-pbc[bot]

/attempt #395

Options

Ayush-Vish avatar Jul 13 '24 03:07 Ayush-Vish

@unworld11 Are you still working on this issue.

Ayush-Vish avatar Jul 13 '24 04:07 Ayush-Vish

no i am unassigning myself.

unworld11 avatar Jul 13 '24 07:07 unworld11

/attempt #395

Options

lata-11 avatar Jul 13 '24 15:07 lata-11

[!NOTE] The user @Ayush-Vish is already attempting to complete issue #395 and claim the bounty. We recommend checking in on @Ayush-Vish's progress, and potentially collaborating, before starting a new solution.

algora-pbc[bot] avatar Jul 13 '24 15:07 algora-pbc[bot]

@Ayush-Vish: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then šŸ™

algora-pbc[bot] avatar Jul 16 '24 03:07 algora-pbc[bot]

@lata-11: Reminder that in 4 days the bounty will become up for grabs, so please submit a pull request before then šŸ™

algora-pbc[bot] avatar Jul 16 '24 15:07 algora-pbc[bot]

/attempt #395

Implementation Plan

  1. Update Configuration Schema:

    • Add a new optional field subscription_url to the configuration schema.
  2. Modify Subscription Logic:

    • Update the logic to use the provided subscription_url if available, otherwise generate the default URL.
  3. Update Documentation:

    • Reflect the new subscription_url configuration option in the documentation.
Options

HemanthGangula avatar Jul 21 '24 04:07 HemanthGangula