keep icon indicating copy to clipboard operation
keep copied to clipboard

fix: workflow id and name usage

Open vishwamartur opened this issue 1 year ago • 4 comments

Related to #1885

Update workflow parsing to use id as id and name as name, generate different UUID if id is not provided, and add validation for configuration errors.

  • keep/parser/parser.py

    • Update _get_workflow_id to use workflow.get("id") for id and workflow.get("name") for name.
    • Add logic to generate a different UUID if workflow.get("id") is not provided.
    • Update _parse_workflow to use workflow.get("name") for name.
  • keep/api/models/db/workflow.py

    • Add a new field invalid to mark workflows with configuration errors.
    • Update the Workflow class to include the invalid field.
  • keep/api/routes/workflows.py

    • Update create_workflow and create_workflow_from_body to generate a different UUID if workflow.get("id") is not provided.
    • Add validation logic to mark workflows with configuration errors as invalid.
  • tests/test_parser.py

    • Add test cases to verify that a different UUID is generated if workflow.get("id") is not provided.
    • Add test cases to verify that workflows with configuration errors are marked as invalid.

vishwamartur avatar Nov 28 '24 07:11 vishwamartur

@vishwamartur is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 28 '24 07:11 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 28 '24 07:11 CLAassistant

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

github-actions[bot] avatar Nov 28 '24 07:11 github-actions[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 7:53am

vercel[bot] avatar Dec 09 '24 07:12 vercel[bot]

This is open for more than a month. Closing for now, please re-open if it's relevant cc: @vishwamartur @Matvey-Kuk

talboren avatar Dec 29 '24 18:12 talboren