keep icon indicating copy to clipboard operation
keep copied to clipboard

[🐛 Bug]: Adding filter to workflow execution table cause refresh of the page

Open shahargl opened this issue 1 year ago • 6 comments

https://github.com/user-attachments/assets/b5562517-104d-43c6-994f-c59ff40d4515

shahargl avatar Sep 29 '24 10:09 shahargl

@rajeshj11 FYI: i think this was intentional as it fetches data from the backend (filtering happens in the backend)

talboren avatar Sep 29 '24 10:09 talboren

@rajeshj11

even if true - there are only 3 filters ("static", "manual" and "alert") why not fetching them ahead? second, in nextjs, only the table should refresh, not all the page (which takes more time to load). the problem is that it changes the URL and then router.push which is navigating to another page.

shahargl avatar Sep 29 '24 11:09 shahargl

@shahargl @talboren there are only 3 filters ("static", "manual" and "alert") . we can fetch but additional custom handling needs to be done at the frontend layer.

will work on the feedback/bug. please assign it to me.

  1. Instead of completely repainting the entire page, render only the necessary components.
  2. The selection of any option should not trigger a redirect; only the content on the right side should change.

rajesh-jonnalagadda avatar Sep 29 '24 11:09 rajesh-jonnalagadda

assigned! 🤴

shahargl avatar Sep 29 '24 12:09 shahargl

@shahargl How urgent is this? I committed to helping with the issue below. can I start after that is resolved? https://github.com/keephq/keep/issues/1780

rajesh-jonnalagadda avatar Sep 29 '24 13:09 rajesh-jonnalagadda

This metric indicates the success rate of the workflows

AMANCHAUBEY8822 avatar Sep 29 '24 20:09 AMANCHAUBEY8822