keep icon indicating copy to clipboard operation
keep copied to clipboard
verified publisher icon keephq

[➕ Feature]: Improve workflow validation

Open shahargl opened this issue 1 year ago • 12 comments

  1. Today "id" is being used as an name. This behavior should be deprecated. If an id is supplied, use it, and use name as name https://github.com/keephq/keep/blob/main/keep/parser/parser.py#L37
  2. Deleting an workflow and creating another workflow with the same name shows again all old data since deleting a workflow make it is_deleted=1 and not really deletes the workflow (which is ok). Uploading a workflow without an id should generated different uuid.
  3. Improve validation - mark workflow with some flag that says it won't run (e.g. configuration error) until something will fix it

shahargl avatar Sep 09 '24 13:09 shahargl

@shahargl I would like to work on this. can you please guide me on what are the improvements we need?

rajesh-jonnalagadda avatar Sep 11 '24 10:09 rajesh-jonnalagadda

@rajeshj11 yes! updated ticket.

shahargl avatar Sep 11 '24 11:09 shahargl

@shahargl Can we create two identical workflows?

rajesh-jonnalagadda avatar Sep 11 '24 12:09 rajesh-jonnalagadda

/bounty 50

shahargl avatar Sep 19 '24 12:09 shahargl

💎 $50 bounty • Keep (YC W23)

Steps to solve:

  1. Start working: Comment /attempt #1885 with your implementation plan
  2. Submit work: Create a pull request including /claim #1885 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to keephq/keep!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🔴 @rajesh-jonnalagadda Sep 19, 2024, 12:29:08 PM WIP
🟢 @35C4n0r Sep 24, 2024, 1:32:27 PM WIP
🟢 @Mayank77maruti Feb 14, 2025, 8:38:10 AM WIP

algora-pbc[bot] avatar Sep 19 '24 12:09 algora-pbc[bot]

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@rajeshj11    3 keephq bounties
+ 16 bounties from 7 projects
JavaScript, TypeScript,
HTML
Cancel attempt

rajesh-jonnalagadda avatar Sep 19 '24 12:09 rajesh-jonnalagadda

@Matvey-Kuk is anyone working on this currently? I would like to attempt it.

35C4n0r avatar Sep 24 '24 12:09 35C4n0r

@35C4n0r it's yours!

Matvey-Kuk avatar Sep 24 '24 13:09 Matvey-Kuk

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@35C4n0r    18 keephq bounties
+ 12 bounties from 4 projects
Python, TypeScript,
HTML & more
﹟1771
 Cancel attempt

35C4n0r avatar Sep 24 '24 13:09 35C4n0r

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options @35C4n0r    18 keephq bounties

  • 12 bounties from 4 projects Python, TypeScript, HTML & more ﹟1771 Cancel attempt

@35C4n0r I have already attempted the issue, and although I wasn't able to get my changes merged, I do have some context on the modifications. If needed any assistance on this feature. feel free to reach out to me. I am open to collaborate

rajesh-jonnalagadda avatar Sep 26 '24 11:09 rajesh-jonnalagadda

Can you please give this PR a better indicative name? 🙏🏼

talboren avatar Sep 27 '24 12:09 talboren

Payout for this bounty will be executed via GitHub Sponsors, not via Algora. Please activate https://github.com/sponsors/accounts for your account to receive the payout, sorry for the inconvenience

Matvey-Kuk avatar Oct 14 '24 16:10 Matvey-Kuk

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@Mayank77maruti 1 bounty from 1 project
CSS, Python,
JavaScript & more
﹟3376
 Cancel attempt

Mayank77maruti avatar Feb 14 '25 08:02 Mayank77maruti

@Kiryous I assigned to you since it's related to the work you're doing now. @35C4n0r hope it's ok

Matvey-Kuk avatar Mar 16 '25 13:03 Matvey-Kuk