keep icon indicating copy to clipboard operation
keep copied to clipboard

[🔨 Enhancement]: Secrets Manager - add error handling and exceptions

Open shahargl opened this issue 1 year ago • 1 comments

Current:

  1. BaseSecretManager - read_secret, write_secret as abstract methods
  2. Every deriving manager implements those functions
  3. No error handling

Expected Behaviour

  1. BaseSecretManager - _read_secret, _write_secret as abstract methods
  2. BaseSecretManager - read_secret and write_secret which uses the _ methods with try/except
  3. Every deriving manager implements error handling with at least PermissionError

shahargl avatar Jul 21 '24 10:07 shahargl

i can work on this

BaunaBadmosh avatar Oct 02 '24 19:10 BaunaBadmosh

@shahargl I think it might "hide" some problems if we do it that way (e.g., when something is calling read_secret and expects the exception, or something like that) I'm closing for now and will re-open if it raises in any way

talboren avatar Mar 19 '25 08:03 talboren