keep icon indicating copy to clipboard operation
keep copied to clipboard

[🐛 Bug] `workflowexecution` result fails when result contains datetime

Open talboren opened this issue 1 year ago • 2 comments

Describe the bug When the result of a workflow execution might include datetime object, we're unable to save it in to the database because of a serialization problem.

To Reproduce

  1. TBD

Expected behavior Workflow result should be saved in the DB properly.

Screenshots CleanShot 2024-06-19 at 12 04 33

Additional context

talboren avatar Jun 19 '24 09:06 talboren

@talboren @Matvey-Kuk Hi, I probably found the cause of the bug, check it out https://github.com/keephq/keep/pull/1382

ArtArtem avatar Jul 15 '24 18:07 ArtArtem

@talboren After further exploring the capabilities of SQLAlchemy, I found a more correct way to solve the problem, I'm sure it's better now https://github.com/keephq/keep/pull/1392

ArtArtem avatar Jul 17 '24 10:07 ArtArtem

Labeling this one as a Good First Issue.

@ArtArtem already made a good progress with this issue, his PR is a good starting point to pick this up :)

If you want to work on this, join Slack and we will help: https://slack.keephq.dev/ !

Matvey-Kuk avatar Jan 12 '25 13:01 Matvey-Kuk

This should already been solved, closing as it's probably just obsolete

talboren avatar Apr 04 '25 12:04 talboren