keep icon indicating copy to clipboard operation
keep copied to clipboard

Optimize UI for smaller screens

Open Matvey-Kuk opened this issue 1 year ago • 18 comments

Please don't assign to yourself if you are not going through the interview process:

We are hiring at Keep, and one of the stages in our hiring process is a test task. To make working on a test task more fun, we ask candidates to take any issue from our public GitHub. We also assign a small bounty to thank candidates for their time. Issues with the bounty are popular, so this particular issue is "held" for candidates going through the interview process. Btw, check our open positions if you want to work at Keep! https://www.ycombinator.com/companies/keep

Currently, Keep's UI is optimized for larger screens only. This issue is a series of minor frontend issues I'm facing as a MacBook (13-inch display) user. Take it if you would like to demonstrate UI skills. I'm pretty sure I didn't catch all of the issues ;)

  1. Margins in the list of Providers (and even overflow for some items): Screenshot 2024-06-09 at 15 47 22

  2. Overflow: Screenshot 2024-06-09 at 15 48 19

  3. Margins on the bottom of the Provider configuration page: Screenshot 2024-06-09 at 15 48 48

  4. Give me more space! Screenshot 2024-06-09 at 15 53 32

  5. Too vertical ;) Screenshot 2024-06-09 at 15 54 28

Matvey-Kuk avatar Jun 09 '24 13:06 Matvey-Kuk

/bounty 20

Matvey-Kuk avatar Jun 09 '24 13:06 Matvey-Kuk

@p1kalys: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

algora-pbc[bot] avatar Jun 09 '24 14:06 algora-pbc[bot]

I'll be working on this if not @p1kalys

srikary12 avatar Jun 09 '24 14:06 srikary12

@Matvey-Kuk Can it be assigned to me?

/attempt https://github.com/keephq/keep/issues/1220

Options

asr2003 avatar Jun 09 '24 15:06 asr2003

@asr2003: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

algora-pbc[bot] avatar Jun 09 '24 15:06 algora-pbc[bot]

@Matvey-Kuk Can you assign it to me?

srikary12 avatar Jun 10 '24 06:06 srikary12

/attempt #1220

Options

srikary12 avatar Jun 10 '24 07:06 srikary12

@srikary12: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

algora-pbc[bot] avatar Jun 10 '24 07:06 algora-pbc[bot]

Hi @srikary12, I can't match your account with anyone interviewing for Keep's engineering position. Please reach out to me in DM!

Matvey-Kuk avatar Jun 10 '24 07:06 Matvey-Kuk

The required changes are made in the PR

srikary12 avatar Jun 10 '24 08:06 srikary12

/attempt #1220

Algora profile Completed bounties Tech Active attempts Options
@hrshkshri 1 bounty from 1 project
JavaScript, C,
Python & more
Cancel attempt

hrshkshri avatar Jun 10 '24 13:06 hrshkshri

@hrshkshri: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

algora-pbc[bot] avatar Jun 10 '24 13:06 algora-pbc[bot]

Hi @hrshkshri, I can't match your account with anyone interviewing for Keep's engineering position. Please reach out to me in DM!

Matvey-Kuk avatar Jun 10 '24 14:06 Matvey-Kuk

Hi @hrshkshri, I can't match your account with anyone interviewing for Keep's engineering position. Please reach out to me in DM!

Hello there... Dropped a message

hrshkshri avatar Jun 10 '24 14:06 hrshkshri

đź’ˇ @srikary12 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

algora-pbc[bot] avatar Jun 13 '24 02:06 algora-pbc[bot]

@Matvey-Kuk @talboren - workflows page looks bad on small screen: CleanShot 2024-06-24 at 09 05 20@2x

shahargl avatar Jun 24 '24 06:06 shahargl

Hey, @Matvey-Kuk, I'm coming back with a small PR to fix the issues described—#1491. Please have a look when you have time.

Kiryous avatar Jul 30 '24 19:07 Kiryous

/bounty 75

Matvey-Kuk avatar Jul 31 '24 13:07 Matvey-Kuk

/attempt https://github.com/keephq/keep/issues/1220

Kiryous avatar Aug 26 '24 14:08 Kiryous