readability

readability copied to clipboard

Misc doc changes

1

Besides other documentation changes, this commit ensures the generated HTML doc for HexDocs.pm will become the source of truth for this Elixir library and leverage on latest features of ExDoc.

kianmeng

Dependency versions too old

2

``` {:httpoison, "~> 0.13.0"}, ``` This forces everyone with an updated codebase to use `override: true` ``` {:httpoison, "~> 1.5", override: true} ``` I know it's hard to keep the...

alexandremcosta

zpeters

zpeters

Bump Floki and HTTPoison versions

1

Tried to pull it into my app and run, but the dependency lock on HTTPoison and Floki are way too outdated. Do let me know if you need anything else...

edisonywh

function Floki.Selector.match?/2 is undefined or private.

8

`{:readability, "~> 0.8.0"}` --- ``` x = Readability.summarize("https://sergiotapia.me/pluralizing-strings-in-javascript-es6-b5d4d651d403") Error: 15:40:05 web.1 | ** (UndefinedFunctionError) function Floki.Selector.match?/2 is undefined or private. Did you mean one of: 15:40:05 web.1 | 15:40:05 web.1...

sergiotapia

Example URL: "http://www.techhive.com/article/3158435/home-tech/43-off-tp-link-smart-led-wi-fi-light-bulb-dimmable-and-alexa-compatible-deal-alert.html#tk.rss_smartappliance" Can summarize it: ``` iex(6)> Readability.summarize("http://www.techhive.com/article/3158435/home-tech/43-off-tp-link-smart-led-wi-fi-light-bulb-dimmable-and-alexa-compatible-deal-alert.html#tk.rss_smartappliance") %Readability.Summary{article_html: "TP-Link has discounted its 50W smart bulb 43% to just $19.99. Use the Kasa app to turn on/off or dim...

edevil

Readability.article(raw_html) encounter error

5

v: 0.6.1 ``` ** (FunctionClauseError) no function clause matching in Floki.DeepText.get_text/3 lib/floki/deep_text.ex:28: Floki.DeepText.get_text(nil, "", "") lib/readability/helper.ex:75: Readability.Helper.text_length/1 lib/readability/article_builder.ex:38: Readability.ArticleBuilder.build/2 ```

rupertqin

Currently in article we do `opts = Keyword.merge(@default_options, opts)`, in summarize we don't. It should be unified - we probably want to use default options also in summarize.

Valian