keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard

Fix launching proxy service with Flatpak

Open droidmonkey opened this issue 2 years ago • 1 comments

  • Fixes #8655

Testing strategy

Tested using 2.7.3 Flatpak distribution with manual edits to the browser json file. Will test with a custom flatpak build of this branch as well.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

droidmonkey avatar Oct 27 '22 11:10 droidmonkey

Codecov Report

Base: 64.30% // Head: 64.28% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (4c41ca2) compared to base (422fd91). Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8680      +/-   ##
===========================================
- Coverage    64.30%   64.28%   -0.02%     
===========================================
  Files          341      341              
  Lines        44330    44330              
===========================================
- Hits         28502    28495       -7     
- Misses       15828    15835       +7     
Impacted Files Coverage Δ
src/browser/NativeMessageInstaller.cpp 24.17% <ø> (ø)
src/gui/Clipboard.cpp 78.95% <0.00%> (-7.02%) :arrow_down:
src/core/FileWatcher.cpp 86.75% <0.00%> (-1.20%) :arrow_down:
src/core/Entry.cpp 82.52% <0.00%> (-0.20%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 27 '22 13:10 codecov-commenter

Hi,

it seems this doesn't work with Firefox 106.0.5 from Snap with WebExtensions Portal (which work with keepassxc from deb). If I observed it correctly, Keepassxc-browser from Firefox-Snap triggers keepassxc-binary without any args.

If I change path in the json to /var/lib/flatpak/app/org.keepassxc.KeePassXC/current/active/files/bin/keepassxc-proxy, then the communication between Firefox-Snap and Keepassxc-Flatpak works.

I'm not sure where is the best place to open a new bugreport.

Best

Keywan

prometoys avatar Nov 11 '22 07:11 prometoys

Hello, @droidmonkey!

I'm using Google Chrome 108 and KeePassXC 2.7.4 on Fedora Silverblue 37, both are flatpaked.

It doesn't seem to work, because I get a message that the key exchange was not successful.

I tried setting the path value in the org.keepassxc.keepassxc_browser.json file to

/home/user/.local/share/flatpak/exports/bin/org.keepassxc.KeePassXC

then directly to

/home/user/.local/share/flatpak/app/org.keepassxc.KeePassXC/current/active/files/bin/keepassxc-wrapper

and finally to

/home/user/.local/share/flatpak/app/org.keepassxc.KeePassXC/current/active/files/bin/keepassxc-proxy

but nothing works.

I also tried to build keepassxc-proxy-rust and connect to KeePassXC through it, but that doesn't work either.

I seem to be doing something wrong, could you please guide me how to do it right?

Thank you.

ivanov17 avatar Jan 11 '23 08:01 ivanov17

I don't think Chrome flatpak (or snap) supports native messaging yet. Only Firefox does.

droidmonkey avatar Jan 11 '23 11:01 droidmonkey