Replace hide notes checkbox with a button when notes are hidden by default

[r0ckarong]

Overview

Each entry has a Notes field that you can put additional text content into. This has a toggle checkbox. Even if I remove the check mark from this box the notes entry field is always visible when reopening the entry. The intention and UX for this checkbox and the Notes field/section are not clear.

I'm pretty sure this is not a duplicate of https://github.com/keepassxreboot/keepassxc/issues/5571 but probably related.

Steps to Reproduce

1. Create an entry
2. Uncheck the Notes checkbox (adding actual contents or not is irrelevant)
3. Save and close the entry
4. Open entry again
5. Entry field is visible with contents

Expected Behavior

As I understand this field and the checkbox it should allow the user to enter notes and store them with the entry.

On unchecking the box, the notes section gets hidden from the entry view (I don't understand why that would be useful though). The text shown in place of the notes entry field reads "Toggle the checkbox to reveal the notes section." (emphasis by me). This wording suggests that, unless the checkbox is active, the contents are hidden.

Right now, the box basically does nothing because even when unchecked the notes are visible when reopening the entry. Furthermore the notes "hidden" in this way are displayed in the Notes column of the entries list.

If this checkbox should hide the notes from the entry then I would argue that they should be omitted from the Notes column in the entries list as well. What scenario would I want to hide a Note in the entry itself but have it show in the list? Maybe I'm just fundamentally misunderstanding what these Notes should be used for and why one would want to hide that Notes section.

Personally, I use the notes to store things like customer numbers that are associated with an entry but have nothing to do with the login but might come up during its use.

Actual Behavior

The checkbox for Notes disables the section but this state is not saved. You uncheck the box, save the entry and on opening the entry again, the box is checked and the Notes visible.

Futhermore, notes that are supposedly "hidden" in this way are displayed in the Notes column of the entries list.

Context

KeePassXC - Version 2.6.4 Revision: 34a78f0

Qt 5.15.2 Debugging mode is disabled.

Operating system: Windows 10 Version 2009 CPU architecture: x86_64 Kernel: winnt 10.0.19042

Enabled extensions:

• Auto-Type
• Browser Integration
• SSH Agent
• KeeShare (signed and unsigned sharing)
• YubiKey

Cryptographic libraries:

• libgcrypt 1.9.1-unknown

[droidmonkey]

You missed an application setting under security tab which hides notes by default. This hides the notes in the entry edit view and you need to check the box to reveal them.

[r0ckarong]

You missed an application setting under security tab which hides notes by default. This hides the notes in the entry edit view and you need to check the box to reveal them.

I did indeed. Since I am not using this feature it didn't occur to me that there would be a specific option to hide by default. The checkbox just didn't seem to be doing what I expected it to do.

Thank you for the quick response!

[droidmonkey]

It sure is confusing though and the checkbox does nothing as you witnessed otherwise. We can clean that up.