keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard

Revert Auto-Type change that caused race condition

Open droidmonkey opened this issue 5 months ago • 2 comments

  • Fixes #12723

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

droidmonkey avatar Nov 25 '25 23:11 droidmonkey

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 64.39%. Comparing base (967dc59) to head (f48fd6b). :warning: Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12738      +/-   ##
===========================================
- Coverage    64.42%   64.39%   -0.02%     
===========================================
  Files          378      378              
  Lines        39845    39844       -1     
===========================================
- Hits         25667    25657      -10     
- Misses       14178    14187       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 25 '25 23:11 codecov[bot]

Oh, we're having this random test failure again:

FAIL!  : TestTools::testBackupFilePatternSubstitution(Complex custom time pattern) Compared values are not the same
   Actual   (Tools::substituteBackupFilePath(pattern, dbFilePath)): "./25/KeePassXC_20251126_041909.old.kdbx"
   Expected (expectedSubstitution)                                : "./25/KeePassXC_20251126_041908.old.kdbx"

https://ci.keepassxc.org/buildConfiguration/KeePassXC_UbuntuLinux/276042?showLog=276039_1608_1499&logFilter=debug&logView=flowAware

This seems to be happening when the second lapses during the generation of the test pattern matrix and the actual test execution: https://github.com/keepassxreboot/keepassxc/blob/967dc5937f1f69e601f7aecbc600ef9027cc5043/tests/TestTools.cpp#L157

My recommended fix would be simply to remove the second from the pattern. This could still happen at the minute mark, but it's way less likely.

phoerious avatar Nov 26 '25 09:11 phoerious