keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard
verified publisher icon keepassxreboot

Resolve REF:P@I during healthCheck

Open daxsis opened this issue 3 months ago • 3 comments

Add reference to current entry to PasswordWiget, which resolves {REF:P@I:....} if it exists, if not it will treat the input as raw text and pass through PasswordHealth check. FIXES #12671

Screenshots

image

Testing strategy

make test ARGS+="--output-on-failure" ARGS+=-j8 ARGS+="-E testgui" 100% tests passed, 0 tests failed out of 42

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

daxsis avatar Nov 16 '25 11:11 daxsis

Instead of exposing entry to the password widget, I recommend a more functional approach to this. Pass a lambda function to something like "passwordStrengthCalculator" which can take these things into account.

droidmonkey avatar Nov 16 '25 14:11 droidmonkey

I will refactor into functional, is there anything else? I see there is no answer on the issue comment I posted, not sure if to make it ready to merge after or wait for additional input into the change of the handling the temporary m_entry.

I can change it to ready for review and work on the m_entry solution meanwhile this gets merged.

daxsis avatar Nov 24 '25 05:11 daxsis

The temporary new entry issue has been a problem for many years.

droidmonkey avatar Nov 24 '25 11:11 droidmonkey