keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard

Window title bar on macOS doesn't offer a path browser any more on CMD-click

Open lindenstruth opened this issue 7 months ago • 7 comments

Have you searched for an existing issue?

  • [x] Yes, I tried searching and reviewed the pinned issues

Brief Summary

Older versions had a Popup Button in the title bar which, when CMD-clicking onto the window title, sort of simulated the most important part of those UI Elements, which are present in all document windows of NSDocument based native macOS apps, and which allow you to browse the current document's folder by opening it in a Finder window (the native NSDocument window one offers a lot more, incl. renaming the opened file for example).

It's a bit unfortunate that this popup menu is now gone, and I wonder if that was intentional or by mistake. It made life a lot easier, particularly when having the database history (Recent Databases) disabled for privacy/security reasons.

Version 2.7.1 still had it, so it must have been removed afterwards. Unfortunately I can't make a screenshot of it, since this version prevents me from doing just that (I just get an empty screen). But it seems to be merely a standard menu listing all path components:

Image

Steps to Reproduce

  1. Open a database file, no need to authenticate
  2. CMD-click onto the title

Expected Versus Actual Behavior

CMD-clicks on the window's title used to show a little menu listing the path components of the currently opened database file's full path in order to browse them on selection in a Finder window. Later versions don't have that any more.

KeePassXC Debug Information

Mac Mini 2018
macOS Sonoma, Version 14.7.6 (23H626)
no developer betas

Operating System

macOS

Linux Desktop Environment

None

Linux Windowing System

None

lindenstruth avatar Jun 13 '25 11:06 lindenstruth

The file open dialog is managed by Qt, so not sure they may have disabled this behavior? Either way we didn't explicitly remove it (had no idea that existed) so we cant add it back.

droidmonkey avatar Jun 13 '25 12:06 droidmonkey

#422 is the pull request that added this feature.

phoerious avatar Jun 13 '25 12:06 phoerious

@phoerious that's exactly what I meant. Not in the file open dialog but on the main window. So someone must have removed it, either intentionally (maybe it did collide with something in a later qt version) or by accident. It would really be nice to have it back.

lindenstruth avatar Jun 13 '25 12:06 lindenstruth

That was indeed removed. Here's the commit that did that: https://github.com/keepassxreboot/keepassxc/commit/832340e209949be1ef4d057c70dc7a08450f3f36#diff-1db3ae4f87f707eca52da4b7068c06ea14a9c5f27ab38eafc1f864fe0655fec0L1052

phoerious avatar Jun 13 '25 12:06 phoerious

What a strange feature, but i guess we can consider adding this back. We removed those calls for a reason.

https://github.com/keepassxreboot/keepassxc/pull/11542

droidmonkey avatar Jun 13 '25 13:06 droidmonkey

it's actually been around on macOS for quite a while, nothing strange about lt. Has been introduced with macOS 10.10 (Yosemite) over 10 years ago... 🤓 So we long-time macOS users have really gotten used to it very much.

The original one can do a lot more and comes in extremely handy when handling files and document bundles:

Image

lindenstruth avatar Jun 13 '25 13:06 lindenstruth

What a strange feature, but i guess we can consider adding this back. We removed those calls for a reason.

#11542

I don't see why this particular part was removed. This looks like an accidental removal to me.

phoerious avatar Jun 13 '25 14:06 phoerious