Fix minor issues in the app

[droidmonkey]

• Fixes #11808

  • Don't show tear off menu or option to tear off if there are no tags
  • Fix "No Tags" not being shown on first hover
  • Fix issues when using a tag named "No Tags"

• Fixes https://github.com/keepassxreboot/keepassxc/issues/11662 - disable the save button when viewing Password Generator and Application Settings to restore previous behavior of toolbar

• Fixes https://github.com/keepassxreboot/keepassxc/issues/11891

• Fixes https://github.com/keepassxreboot/keepassxc/issues/11357

  • Introduces validity parameter to TOTP generator function for future use elsewhere in the code base

• Fixes #11856

  • Set the minimum recommended wordlist size to 1,296 - equal to the EFF Short List
  • Issue a clear warning when using a smaller wordlist but do not prevent generation of passphrases

• Remove start menu shortcuts on uninstall

• Fixes #12070

Testing strategy

Tested on Windows

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 65.04854% with 36 lines in your changes missing coverage. Please review.

Project coverage is 64.24%. Comparing base (c4b4be4) to head (dd0574c). Report is 9 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/gui/PasswordGeneratorWidget.cpp	44.44%	10 Missing :warning:
src/gui/MainWindow.cpp	18.18%	9 Missing :warning:
src/autotype/AutoType.cpp	0.00%	7 Missing :warning:
src/core/Totp.cpp	81.25%	3 Missing :warning:
src/gui/MessageBox.cpp	0.00%	2 Missing :warning:
src/autotype/AutoTypeSelectDialog.cpp	0.00%	1 Missing :warning:
src/browser/BrowserService.cpp	0.00%	1 Missing :warning:
src/core/Entry.cpp	83.33%	1 Missing :warning:
src/gui/DatabaseWidget.cpp	50.00%	1 Missing :warning:
src/gui/EntryPreviewWidget.cpp	93.33%	1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12102      +/-   ##
===========================================
+ Coverage    63.89%   64.24%   +0.35%     
===========================================
  Files          369      375       +6     
  Lines        38943    39292     +349     
===========================================
+ Hits         24882    25241     +359     
+ Misses       14061    14051      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[xboxones1]

1. During testing I noticed that the problem with TOTP is not only on the preview panel but also when viewing from the context menu TOTP -> Show TOTP

2. If the default TOTPs are hidden in the preview panel, the progress bar is not hidden and continues to show.

[droidmonkey]

Egad, well my fix works for the pop up panel too so will apply there. Interesting I didn't see the progress bar stay on but will add more assurance its hidden.

[varjolintu]

I also see this weird space inside the word in macOS:

[droidmonkey]

Ok got both issues fixed:

Also properly hiding the progress bar and text label if the TOTP code isn't valid on the popup dialog.

[varjolintu]

Maybe the copy button should be disabled also if the TOTP is not valid? After all it's just copying the "Invalid Key" value to clipboard.

[droidmonkey]

Added another fix for the passphrase generator wordlist size handling:

I also added disabling the copy button on the TOTP dialog if the code is invalid

[xboxones1]

And show qr-code can also be disabled

[droidmonkey]

The buttons are only testing if totp is configured... that would be a bigger change to the code logic deep in the totp settings. I will consider this.

[droidmonkey]

Ok well this turned out much easier than I expected and actually improves a lot of behaviors:

Give this a thorough test, but I think I hit everything, even copying TOTP from the auto-type dialog and browser extension

[dqnk]

Hi, I was checking out this branch for the password generation with shorter wordlists and I found a bug which does not happen in the current latest version (KeePassXC 2.7.10). If you open the password generator, set the password length to very short (e.g. 4 characters), the regenerate password button will get blocked and it will stay blocked even if you click on the passphrase tab and try to generate any (even adequately long) passphrase.

Steps to reproduce:

1. Open the password generator (the die with 3 dots in top bar)
2. Select the tab to generate a password (from the Password/Passphrase tabs in generator menu). Set password length to 3, click Advanced, select all character groups and have the "Pick characters from every group" selected. The regenerate button will become greyed out. This is intended, I'm assuming because the password is too short to fit a character from every group.
3. Go to the Passphrase tab without closing the "Advanced" menu first. The button will still be grayed out. I don't think this is intended.

(this is just a random thing I noticed on this branch, I did not review the code changes, but this does not happen in KeePassXC 2.7.10).

[droidmonkey]

Good catch, probably just need to explicitly do an "enable" operation on the button since it used to be dynamic.

and fixed it

[xboxones1]

[xboxones1]

@droidmonkey, I checked and it still hasn't been fixed. Or don't you see what the problem is?

[droidmonkey]

What hasn't been fixed? I could not replicate your gif

[xboxones1]

@droidmonkey, I outlined the steps to reproduce the issue, but you marked the message as outdated. I thought a GIF would be more helpful.

1. In the security settings, disable the option to hide TOTP in the preview panel.
2. Expand the preview panel so that it is visible after unlocking the database.
3. After unlocking, ensure that TOTP is configured in the first entrey that is opened.
4. After unlocking the database, TOTP should display in the preview panel, but it does not. You have to click twice, as shown in the GIF. This is the bug.
5. This issue occurs on Linux, but I can build on Windows to test

[droidmonkey]

Ah, I figured it out, fix inbound