keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard

Add timeout to SSH Agent streams

Open droidmonkey opened this issue 1 year ago • 1 comments

  • Fixes #11128

Testing strategy

Pending testing in a replicated environment

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

droidmonkey avatar Sep 23 '24 01:09 droidmonkey

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.76%. Comparing base (5d24495) to head (cd2b2da). Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11290      +/-   ##
===========================================
- Coverage    63.78%   63.76%   -0.02%     
===========================================
  Files          362      362              
  Lines        38072    38070       -2     
===========================================
- Hits         24282    24273       -9     
- Misses       13790    13797       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 23 '24 01:09 codecov[bot]

I couldn't get the reproduce steps to work. If I make a custom systemd service everything works as expected, but without it the agent doesn't even run.

varjolintu avatar Nov 06 '24 18:11 varjolintu

Merging this since OP said it fixed their issue and there is no harm in having a defined timeout as 99% of the time the transaction is near instant.

droidmonkey avatar Nov 10 '24 14:11 droidmonkey