keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard

Add Proton Pass importer

Open droidmonkey opened this issue 1 year ago • 1 comments

  • Closes #10465

We will only support unencrypted json exports since Proton Pass uses PGP for encrypted exports for some reason. We also do not support passkey exports from Proton Pass yet.

Screenshots

image

Testing strategy

Added unit tests

Type of change

  • ✅ New feature (change that adds functionality)

droidmonkey avatar Aug 25 '24 20:08 droidmonkey

Codecov Report

Attention: Patch coverage is 81.42857% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.97%. Comparing base (0cb0373) to head (5cd9d73). Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/wizard/ImportWizardPageReview.cpp 33.33% 12 Missing :warning:
src/format/ProtonPassReader.cpp 90.99% 10 Missing :warning:
src/gui/DatabaseTabWidget.cpp 0.00% 2 Missing :warning:
src/gui/wizard/ImportWizardPageSelect.cpp 71.43% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11197      +/-   ##
===========================================
+ Coverage    63.88%   63.97%   +0.09%     
===========================================
  Files          362      364       +2     
  Lines        38147    38277     +130     
===========================================
+ Hits         24367    24486     +119     
- Misses       13780    13791      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 25 '24 20:08 codecov[bot]