keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard

Adding Tags with right click menu to multiple entrees in search results misleading

Open b3nks opened this issue 7 months ago • 1 comments

Overview

With the aim to add a tag to multiple search results, all the tags already given may be deleted.

Steps to Reproduce

  1. add a password entree and give tag bar
  2. add 3 password entrees for domain foo.tld
  3. add tag boo to all entrees
  4. Add a Tag foo to one of the entrees
  5. search for foo.tld to get a list of all entrees
  6. mark all entrees and right click
  7. choose tags
  8. recognize that the icon seems to show the status "☑ foo", "__ bar" and "☑ boo" and click "☑ foo"
  9. recognise non of the entrees has a tag foo anymore, and also the tag foo is completely gone

Expected Behavior

There should be an option to either delete the already given tags or to add the tags not given. The ☑ is obviously supposed to show the status but is misleading as it is not showing the correct status for all marked entrees.

Actual Behavior

  • Status ☑ foo is shown for all entrees
  • By clicking "☑ foo" all foo tags are deleted.

Proposal

if the tag status of the marked entrees is mixed it should show action and status:

  • Tags
    • ➕ foo (add to all selected)
    • ❌ foo (remove from all selected)

    • __ bas
    • ☑ boo

Context

KeePassXC - 2.7.4 Revision: REVISION

Debian 12.5 bookworm Kernel 6.1.0-21-amd64 auf x86_64 Desktop: GNOME GNOME Shell 43.9 Windowing System: x11

b3nks avatar Jul 20 '24 11:07 b3nks