keepassxc icon indicating copy to clipboard operation
keepassxc copied to clipboard

Published 20 hours ago • verified publisher icon keepassxreboot

Add a password discard confirmation

Open Jookia opened this issue 1 month ago • 0 comments

This PR adds a confirmation dialog on password generator close that confirms discarding the password. Fixes #10831 .

Screenshots

A dialog with a warning sign titled "Confirm Close Password Generator." It asks "Discard this password forever?" and lists two options: Discard and No

Testing strategy

Tests are currently broken: Something about MessageBox::setNextAnswer is blocking the closing of the database in the test. Once this is fixed (I need help with this please) I will write tests that check:

  • Closing can be aborted by clicking no
  • Clicking yes always closes the dialog

Type of change

  • ✅ New feature (change that adds functionality)

Jookia avatar Jun 28 '24 01:06 Jookia