keepassxc-browser icon indicating copy to clipboard operation
keepassxc-browser copied to clipboard

Locked symbol still displayed next to username fields in browser after unlocking database

Open ep0ns opened this issue 2 years ago • 13 comments

##Current Behaviour When opening a page that has credential fields and the database is locked, the "keepass database locked" symbol is showed next to the username field. After unlocking the database, the locked symbol is still displayed . Only after a page reload the unlocked symbol is displayed.

Screenshot of locked symbol: image

Expected Behavior

After unlocking the database, the correct symbol is showed next to the username on the current page. No page reload is necessary.

Steps to Reproduce (for bugs)

  1. Lock database
  2. Open any page with credential fields
  3. See the locked symbol next to the username field
  4. Click on the field to unlock the database
  5. See that still the locked symbol is displayed next to the username field, but credential filling is available

Debug info

KeePassXC - 2.7.1 KeePassXC-Browser - 1.7.12 Operating system: Win Browser: Chrome

ep0ns avatar Apr 27 '22 07:04 ep0ns

Sometimes the "broadcast" messages like database-unlocked are not retrieved properly (don't know why). This is why the status doesn't change on icons. I'll need to adjust the icon state update to a more reliable one.

varjolintu avatar Apr 27 '22 07:04 varjolintu

I encountered a similar situation, and even if I reload the page, it still show the locked icon and the database is still locked.

OptimusPrimeme avatar May 07 '22 15:05 OptimusPrimeme

This might have solved it https://github.com/keepassxreboot/keepassxc-browser/pull/1621. Test the current develop branch if you can, thanks.

varjolintu avatar Jun 04 '22 07:06 varjolintu

Still have the issue? It should be fixed.

varjolintu avatar Jul 17 '22 07:07 varjolintu

I am experiencing the same problem as @ep0ns. I always need to reload login pages after unlocking a database.

Browser: Firefox 110 KeePassXC version: 2.7.4 Extension version: 1.8.5.1

aumouvantsillage avatar Mar 16 '23 07:03 aumouvantsillage

@aumouvantsillage Anything in the JavaScript consoles?

varjolintu avatar Mar 16 '23 08:03 varjolintu

@varjolintu Nothing in the JavaScript console.

Actually, I have misread the original bug report. In the steps to reproduce, it says "the locked symbol is displayed [...] but credential filling is available".

In my case:

  • If I unlock the database by clicking on the button "Reopen the database" of the browser extension, everything works correctly.
  • If I unlock the database from the KeePassXC window, the lock symbol disappears from the extension button in the toolbar, but there is still a lock symbol in the login form. Autofilling the credentials does not work.

aumouvantsillage avatar Mar 16 '23 13:03 aumouvantsillage

@aumouvantsillage First this sounded like this but you are already using 2.7.4. And I remember I already fixed a bug like that in the extension. Does this happen right after reconnect? Does it matter if you refresh the web page and then unlock the database from KeePassXC?

varjolintu avatar Mar 16 '23 13:03 varjolintu

Does this happen right after reconnect?

I'm not sure what "after reconnect" means in this context. I usually keep my computer on or in suspend mode. On wake-up, there are usually a few web sites where I need to login again. If the database is locked, I always need to refresh the page after unlocking.

Does it matter if you refresh the web page and then unlock the database from KeePassXC?

It makes no difference for me.

aumouvantsillage avatar Mar 16 '23 17:03 aumouvantsillage

@aumouvantsillage Are you using Windows? It's a reported bug that suspend interferes with the connection.

varjolintu avatar Mar 16 '23 19:03 varjolintu

No. I'm using Fedora 37.

aumouvantsillage avatar Mar 16 '23 20:03 aumouvantsillage

You can try to kill keepassxc-proxy and make a reconnect from the extension popup next time after you wake up from suspend.

varjolintu avatar Mar 16 '23 20:03 varjolintu

KeePassXC - 2.7.6 KeePassXC-Browser - 1.8.8 Operating system: MacIntel Browser: Chrome/Chromium 116.0.0.0

Same issue is present for me too. If there any logs i could provide or help with debug. I'll gladly do it.

flops avatar Sep 26 '23 20:09 flops