satoru icon indicating copy to clipboard operation
satoru copied to clipboard

Implemented test for pricing utils. waiting for #417 to be completed

Open ametel01 opened this issue 1 year ago • 2 comments

PR Type:

  • [x] Refactoring
  • [x] Testing

Current Behavior:

The function apply_exponent_factor() was missing, and no tests were available for apply_impact_factor(). Resolves: #494

Updated Behaviour:

Testing parameters mirror those found in GMX's test.

Breaking Change Introduced?

No

ametel01 avatar Oct 06 '23 14:10 ametel01

Hey ! Thanks but @StarkFishinator already had an ongoing PR on this here and he was assigned on the issue so we'll leave him the priority for the 'apply_exponent_factor' part

zarboq avatar Oct 09 '23 10:10 zarboq

I'll remove the changes in utils leaving only the tests, and draft this PR until utils are completed.

ametel01 avatar Oct 09 '23 12:10 ametel01