madara icon indicating copy to clipboard operation
madara copied to clipboard

feat: compute state root in client instead of runtime

Open AbdelStark opened this issue 1 year ago • 6 comments

Compute Global State Root in Client Instead of Runtime

Description

The goal of this issue is to move the computation of the global state root from the runtime to the client. This computation is a heavy process that consumes a lot of time and resources in the block production. By moving it to an asynchronous task, we can speed up block production.

Background

Currently, the global state root is computed as defined in the Starknet specs and fed into the block. A potential solution to speed up this process would be to include the state root of block N - 1 in the block header N, instead of the state root of the block N. However, for this to save time, it would need to be done in an asynchronous manner.

Tasks

  1. Research: Understand the current process of computing the global state root and how it can be moved to the client.
  2. Design: Create a design document detailing how the global state root computation will be moved to the client and made asynchronous. This should include any necessary changes to the existing architecture.
  3. Implementation: Implement the design, ensuring that the new process for computing the global state root is fully functional and improves block production speed.
  4. Testing: Write comprehensive tests to ensure the new process for computing the global state root works as expected and does not introduce any regressions.
  5. Documentation: Update the project documentation to reflect the new process for computing the global state root.

Acceptance Criteria

  • The global state root is computed in the client instead of the runtime.
  • The computation of the global state root is done asynchronously.
  • The implementation passes all tests.
  • The project documentation is updated to reflect the new process for computing the global state root.

Resources

  • #179
  • #130

AbdelStark avatar Jul 25 '23 07:07 AbdelStark

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Aug 25 '23 00:08 github-actions[bot]

@antiyro you are working on this aren't you?

tdelabro avatar Jan 27 '24 15:01 tdelabro

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Feb 27 '24 00:02 github-actions[bot]

@antiyro you are working on this aren't you?

he is

tdelabro avatar Feb 28 '24 20:02 tdelabro

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Apr 01 '24 00:04 github-actions[bot]

@antiyro when integration in madara?

tdelabro avatar Apr 26 '24 20:04 tdelabro

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar May 27 '24 00:05 github-actions[bot]

@tdelabro @apoorvsadana if @antiyro or anyone else is not working on this one then I can grab this issue

hhamud avatar Jun 03 '24 14:06 hhamud

@hhamud thanks but @antiyro is currently on it

tdelabro avatar Jun 03 '24 14:06 tdelabro

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jul 04 '24 00:07 github-actions[bot]

repository archived in favor of https://github.com/madara-alliance/madara

tdelabro avatar Aug 02 '24 18:08 tdelabro