Investigate moving to `mdbx` instead of `rocksdb`

[AbdelStark]

Description

Investigate and implement a storage backed by an mdbx database instead of rocksdb.

Another possibility would be to try directly using Papyrus storage.

Acceptance criteria

• the implemented solution must pass all tests (unit, integration, end to end)
• performance benchmarks must be provided with a comparison with current storage implementation

Resources

• Rust bindings for MDBX
• Papyrus example

[github-actions[bot]]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

[darmis007]

Will pick up this one @abdelhamidbakhta as we discussed

[AbdelStark]

Will pick up this one @abdelhamidbakhta as we discussed

Assigned to you

[h3lio5]

I can work on this.

[dbejarano820]

@abdelhamidbakhta Hey could I work on this one? Would we want to replace rocksdb with mdbx completely or just add it as a new source?

[EvolveArt]

@abdelhamidbakhta Hey could I work on this one? Would we want to replace rocksdb with mdbx completely or just add it as a new source?

Hey @dbejarano820 , assigned and yes I think you'd want to remove completely and assess performance improvements/degradation.

[dbejarano820]

I will continue to look into this, it's a pretty advanced spike... If anyone is interested in taking the lead, be my guest. I can collaborate.

[shamb0]

Hi @abdelhamidbakhta, could you please assign it to me? I'd like to take it on.

[AbdelStark]

You can do that in addition to the try-runtime work ? I would prefer to avoid multiple tasks in parallel. Especially in this case where both are important, so I would prefer to avoid a bottleneck with one person working on the two in parallel.

[shamb0]

@abdelhamidbakhta, I plan to pick up this task after closing the try-runtime. Testing is in progress, and I expect to close it today or tomorrow. I am confident that I can handle it. 😄

[AbdelStark]

@abdelhamidbakhta, I plan to pick up this task after closing the try-runtime. Testing is in progress, and I expect to close it today or tomorrow. I am confident that I can handle it. 😄

let's go then!

[shamb0]

@abdelhamidbakhta, Do we need to do this investigations on mc-db (crates/client/db/Cargo.toml) ?

[AbdelStark]

@abdelhamidbakhta, Do we need to do this investigations on mc-db (crates/client/db/Cargo.toml) ?

Yes, any progress so far ?

[shamb0]

• I have completed the reference study of the Papyrus storage database.

  https://github.com/starkware-libs/papyrus/blob/main/crates/papyrus_storage/src/db/mod.rs

• I have a high-level overview of the requirements and design.

• I am currently preparing the database adoption layer at Madara in crates/client/db/src/lib.rs.

• I will soon attempt to commit the draft pull request.

[AbdelStark]

• I have completed the reference study of the Papyrus storage database. https://github.com/starkware-libs/papyrus/blob/main/crates/papyrus_storage/src/db/mod.rs
• I have a high-level overview of the requirements and design.
• I am currently preparing the database adoption layer at Madara in crates/client/db/src/lib.rs.
• I will soon attempt to commit the draft pull request.

Awesome! looking forward to it!

[github-actions[bot]]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

[tdelabro]

repository archived in favor of https://github.com/madara-alliance/madara