madara icon indicating copy to clipboard operation
madara copied to clipboard

Published 20 hours ago • verified publisher icon keep-starknet-strange

dev: write tests for tx v3

Open tdelabro opened this issue 10 months ago • 7 comments

TXs V3 were added in the latest rebase.

We need both pallet and RPC tests for those. Pallet to tests failure, edge-cases, and so on. RPC to test the generic flow. And Tx computation too

tdelabro avatar Apr 26 '24 15:04 tdelabro

I would like to try this.

Gerson2102 avatar Apr 26 '24 16:04 Gerson2102

@Gerson2102 enjoy!

tdelabro avatar Apr 26 '24 16:04 tdelabro

@tdelabro Hello mate. Can you tell me the files where is located what i have to test? And if there is other tests that i can use as examples to help me with this issue please?

Gerson2102 avatar Apr 30 '24 21:04 Gerson2102

I'm exploring the starknet-rpc-test directory, i dont know if those tests can help me or something.

Gerson2102 avatar Apr 30 '24 22:04 Gerson2102

@Gerson2102 The exectution of tx is tested in files like crates/pallets/starknet/src/tests/invoke_tx.rs. You can probably add a tests for each type of tx at the end of the dedicated file, using TxV3 for each one.

tdelabro avatar May 06 '24 05:05 tdelabro

I'm exploring the starknet-rpc-test directory, i dont know if those tests can help me or something.

I think you can add a TxV3 test file under RPC where you use all three declare, deploy and invoke txV3 consecutively in the same test. This one should come after the pallet ones

tdelabro avatar May 06 '24 05:05 tdelabro

Also can you write test for the txV3 hashes_computation please. Under crates/primitives/transactions/src/compute_hash.rs

tdelabro avatar May 06 '24 05:05 tdelabro