madara
madara copied to clipboard
Remove hardcoded values in estimate_fee test
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
- Testing
What is the current behavior?
Resolves: #1368
What is the new behavior?
Replace hardcoded value in estimate_fee test with actual fee
Does this introduce a breaking change?
Other information
blocked by #1573
We are going to wait a bit before rebasing and merging this one, okay?
@apoorvsadana Could you help to review this PR? Thanks
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 31.22%. Comparing base (
2e2d580
) to head (583ff0f
). Report is 235 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
- Coverage 40.71% 31.22% -9.49%
==========================================
Files 96 89 -7
Lines 11069 9190 -1879
Branches 11069 9190 -1879
==========================================
- Hits 4507 2870 -1637
+ Misses 6050 5855 -195
+ Partials 512 465 -47
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
repository archived in favor of https://github.com/madara-alliance/madara