madara icon indicating copy to clipboard operation
madara copied to clipboard

Remove hardcoded values in estimate_fee test

Open fishseabowl opened this issue 11 months ago • 1 comments

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Testing

What is the current behavior?

Resolves: #1368

What is the new behavior?

Replace hardcoded value in estimate_fee test with actual fee

Does this introduce a breaking change?

Other information

fishseabowl avatar Mar 20 '24 16:03 fishseabowl

blocked by #1573

We are going to wait a bit before rebasing and merging this one, okay?

tdelabro avatar Apr 26 '24 19:04 tdelabro

@apoorvsadana Could you help to review this PR? Thanks

fishseabowl avatar Jun 04 '24 21:06 fishseabowl

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.22%. Comparing base (2e2d580) to head (583ff0f). Report is 235 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
- Coverage   40.71%   31.22%   -9.49%     
==========================================
  Files          96       89       -7     
  Lines       11069     9190    -1879     
  Branches    11069     9190    -1879     
==========================================
- Hits         4507     2870    -1637     
+ Misses       6050     5855     -195     
+ Partials      512      465      -47     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 04 '24 22:06 codecov[bot]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jul 05 '24 00:07 github-actions[bot]

repository archived in favor of https://github.com/madara-alliance/madara

tdelabro avatar Aug 02 '24 18:08 tdelabro