madara
madara copied to clipboard
ci: add gomu gomu no gatling reports
Pull Request type
- Build-related changes
What is the current behavior?
Currently gomu gomu benchmark is run, but the results are just output to console.
Resolves: #NA
What is the new behavior?
Benchmark results are processed and compared with previous runs. Regression in performance of over 20% causes the pipeline to fail and any failed requests to madara during the benchmark cause the pipeline to fail too.
Does this introduce a breaking change?
No
Other information
@apoorvsadana what is our current situation regarding gomugomu? Is this PR still relevant?
Ya it's relevant. The last PR created by Limechain on gomu gomu has to be merged. There was a bug before rebase in the PR which is solved now. So need to review it now, once we merge that, we can re run this and ensure everything works fine and finally merge
maybe @d-roak and @apoorvsadana will do a better job reviewing this than me
https://github.com/keep-starknet-strange/madara/actions/runs/9062710154/job/24897705455?pr=1501
The CI seems to be stale @isavov
@isavov still red 🥲
@isavov the gomu run fails
@isavov the gomu run fails
Yes, it appears the current version of gomu-gomu is not compatible with madara's current version. Will try to debug further in the next week.
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
repository archived in favor of https://github.com/madara-alliance/madara