madara icon indicating copy to clipboard operation
madara copied to clipboard

dev: Upgrade Madara JSON-RPC specs to v0.6.0

Open antiyro opened this issue 1 year ago • 3 comments

This issue aims to bump Madara current JSON-RPC version from v0.5.1 (implemented here #1313) it is a continuation of this issue #1291 and the full implementation specs can be found here: https://github.com/starkware-libs/starknet-specs/releases

Description

This issue tracks the upgrade of Madara from version 0.5.1 to 0.6.0. The new version introduces several changes and improvements as detailed in the changelog below.

Changelog Summary

  • [x] Execution Resource Counters Changed to Integers #147 by @OmriEshhar1
  • [ ] EMITTED_EVENT Can Now Contain Events from the Pending Block #151 by @ShahakShama
  • [ ] Disallow block_hash/block_number/new_root in PENDING_BLOCK_HEADER Schema #154 by @OmriEshhar1
  • [ ] Introduction of v3 Transactions #149 by @ArielElp
  • [ ] Addition of state_diff to L1_HANDLER and DELEGATE Call Type #161 by @ArielElp
  • [ ] Addition of Resources to Internal Calls within a Trace #160 by @ArielElp
  • [ ] Stricter Restrictions on v3 Fields #169 by @ArielElp
  • [ ] Making Trace Fields Optional (As in 0.5.1) #172 by @ArielElp
  • [ ] Refactor traceTransactions and estimateFee, and Rename STRK to FRI starknet-specs/pull/174 by @ArielElp
  • [ ] Various Other Enhancements and Bug Fixes

Additional Notes

  • New Contributors: Special thanks to @tabaktoni, @marioiordanov, and @FabijanC for their contributions.
  • Full Changelog: v0.5.0...v0.6.0

Action Items

  1. Review the changes and impact on existing functionality.
  2. Plan for integration testing to ensure compatibility.
  3. Update dependencies and configurations as needed.
  4. Perform thorough testing in a controlled environment before deployment.

Discussion

Please share any concerns, suggestions, or insights regarding this upgrade. Your feedback is valuable in ensuring a smooth transition to the new version.

antiyro avatar Jan 06 '24 12:01 antiyro

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Feb 19 '24 00:02 github-actions[bot]

will want to work on this assign me

ebukizy1 avatar Apr 11 '24 18:04 ebukizy1

@antiyro I think we are past this now, can you confirm?

tdelabro avatar May 06 '24 08:05 tdelabro

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jun 06 '24 00:06 github-actions[bot]

yes I confirm @tdelabro

antiyro avatar Jun 06 '24 08:06 antiyro