madara icon indicating copy to clipboard operation
madara copied to clipboard

feat: update declaration of Braavos account in genesis

Open lana-shanghai opened this issue 1 year ago • 9 comments

Feature Request

Describe the Feature Request

Currently in genesis we have these Braavos account class hashes

pub const BRAAVOS_ACCOUNT_CLASS_HASH_CAIRO_0: &str =
    "0x0244ca3d9fe8b47dd565a6f4270d979ba31a7d6ff2c3bf8776198161505e8b52";
pub const BRAAVOS_PROXY_CLASS_HASH_CAIRO_0: &str = "0x06a89ae7bd72c96202c040341c1ee422474b562e1d73c6848f08cae429c33262";

When we try to declare a new account using Braavos, we get errors:

{"jsonrpc":"2.0","error":{"code":40,"message":"Contract error"},"id":0}
{"jsonrpc":"2.0","error":{"code":20,"message":"Contract not found"},"id":0}

because the latest wallet expects a different class hash declared.

In Madara logs, the following class hash is not found 0x03ae692aaf1ded26a0b58cf42490f757563850acea887ed57b4894fee8279063

which is a Braavos account as seen on Starkscan

Compiled program link

Add this class hash and code to the genesis contracts deployed on Madara and verify the flow of setting up a new account on Braavos. This issue is also linked to transaction version which blocks both starknet foundry flow and Braavos, but the temporary removal of the is_query check allows to decouple the Braavos flow from starknet foundry.

lana-shanghai avatar Oct 10 '23 11:10 lana-shanghai

Hello, may I take this?

ftupas avatar Oct 13 '23 09:10 ftupas

Please do!

lana-shanghai avatar Oct 13 '23 12:10 lana-shanghai

Hey @ftupas what's the status on this ?

EvolveArt avatar Nov 08 '23 10:11 EvolveArt

Hey there @EvolveArt, sorry I took a bit of time off to deal with personal things. I started to continue working on this, apologies for the delay

ftupas avatar Nov 10 '23 09:11 ftupas

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Dec 11 '23 00:12 github-actions[bot]

This was recently fixed but broke again with a new Braavos update. Assigning it to myself for now.

apoorvsadana avatar Mar 01 '24 19:03 apoorvsadana

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Apr 02 '24 00:04 github-actions[bot]

@apoorvsadana what is the status here?

tdelabro avatar May 06 '24 09:05 tdelabro

Asked on the group, will update

apoorvsadana avatar May 06 '24 14:05 apoorvsadana

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jun 06 '24 00:06 github-actions[bot]

@apoorvsadana can you document what to do?

tdelabro avatar Jun 06 '24 08:06 tdelabro

Ya, so basically, we want to declare Braavos contracts on Madara and check if using the wallet extension are we able to use Braavos with Madara or not. If it works fine, we can add the new contracts to the genesis. I will ask @ocdbytes to pick it up.

apoorvsadana avatar Jun 06 '24 08:06 apoorvsadana

I will take this

ocdbytes avatar Jun 06 '24 09:06 ocdbytes

@ocdbytes thanks a lot

tdelabro avatar Jun 06 '24 10:06 tdelabro

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jul 07 '24 00:07 github-actions[bot]

repository archived in favor of https://github.com/madara-alliance/madara

tdelabro avatar Aug 02 '24 18:08 tdelabro