joyboy icon indicating copy to clipboard operation
joyboy copied to clipboard

Extract social request handling into a component

Open maciejka opened this issue 1 year ago • 3 comments

OD Hack

This issue is part of ODHack 4.0:

  • description - https://x.com/OnlyDust_com/status/1791035111992934563
  • guidelines - https://onlydust.notion.site/ODHack-Common-Guidelines-Project-leads-5e21836f85ad493f9ca429770af0ad40

Task

Extract SocialPay features into a component. Public key should be in stored in the contract body, SocialPay related methods(currently it is just a single function: handle_transfer_request) and storage (none at the moment) should be in a separate component.

References

  • https://github.com/keep-starknet-strange/joyboy/blob/main/onchain/src/social/account.cairo
  • https://docs.openzeppelin.com/contracts-cairo/0.8.0/components
  • https://book.cairo-lang.org/ch16-02-00-composability-and-components.html

Communication

https://t.me/JoyboyStarknet/949

May the Joy be with you!

maciejka avatar May 22 '24 18:05 maciejka

@maciejka can i work on this issue

Jemiiah avatar May 22 '24 18:05 Jemiiah

Hi, can i jump on this issue

vibenedict avatar May 22 '24 19:05 vibenedict

Hi @maciejka, I'm an ODHack enthusiast having contributed to multiple cairo repositories in previous editions such as https://github.com/carbonable-labs/cairo-erc-7496 and https://github.com/carbonable-labs/cairo-erc-7498

I'm familiar with Cairo components and would love to refactor the SocialAccount using a SocialPay component. I will extract the component in a separate file and modify account.cairo to import the component instead.

saimeunt avatar May 22 '24 23:05 saimeunt