joyboy icon indicating copy to clipboard operation
joyboy copied to clipboard

Implement snip-5 for SocialPay account contract

Open maciejka opened this issue 1 year ago • 8 comments

OD Hack

This issue is part of ODHack 4.0:

  • description - https://x.com/OnlyDust_com/status/1791035111992934563
  • guidelines - https://onlydust.notion.site/ODHack-Common-Guidelines-Project-leads-5e21836f85ad493f9ca429770af0ad40

Task

Implement snip-5 for SocialPay account:

  • account contract is here: https://github.com/keep-starknet-strange/joyboy/blob/main/onchain/src/social/account.cairo
  • it should use: https://docs.openzeppelin.com/contracts-cairo/0.10.0/introspection

References

  • https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-5.md

Communication

https://t.me/JoyboyStarknet/949

May the Joy be with you!

maciejka avatar May 22 '24 18:05 maciejka

Hi @maciejka base on the account contract i work on before , this will be a continuation of my work, kindly assign this issue, A PR will be ready by Monday 27th May, 2024

mubarak23 avatar May 22 '24 18:05 mubarak23

Hi @maciejka I would like to take this task as part of ODHack 4.0: Implement snip-5 for SocialPay account contract . I have experience with Cairo and blockchain development, including implementing standards and contracts. Estimated Delivery Timeline: Start Date: May 23, 2024, Completion Date: June 1, 2024. https://github.com/keep-starknet-strange/joyboy/issues/76. Plus I followed Joyboy on Twitter and joined and talk in telegram group.

juandiegocv27 avatar May 22 '24 18:05 juandiegocv27

Hi, I am Cairo programmer and have a good idea how this would work. I would like to work on this.

VictoriaAde avatar May 22 '24 23:05 VictoriaAde

Thank you for assigning me, I have commenced work on it. I would give regular updates as I go.

VictoriaAde avatar May 23 '24 22:05 VictoriaAde

Hi, @maciejka Would I need to write tests? I think I need to as there's no way to be sure the implementation works as expected.

VictoriaAde avatar May 26 '24 12:05 VictoriaAde

Of course you need to

maciejka avatar May 26 '24 12:05 maciejka

Alright, noted!

VictoriaAde avatar May 26 '24 12:05 VictoriaAde

Hi @maciejka, I have written the code and my tests are passing.

I just made a PR now, please let me know if I'm on the right part. Also, how do I get the interface ID, because I'm currently using a random number as the ID or do you think the interface ID should be added on deployment of the contract?

VictoriaAde avatar May 26 '24 20:05 VictoriaAde

@maciejka, Here the link to the recorded video explanation

For some reason, I can't view my PR anymore. This keeps blinking. image

VictoriaAde avatar Jun 08 '24 00:06 VictoriaAde

I can view my PR now. Do you know what might have gone wrong?

VictoriaAde avatar Jun 08 '24 11:06 VictoriaAde

ment snip-5 for SocialPay account contract . I have experience with Cairo and blockchain development, including implementing standards and contracts. Estima

I can see it: https://github.com/keep-starknet-strange/joyboy/pull/125

maciejka avatar Jun 10 '24 09:06 maciejka