joyboy icon indicating copy to clipboard operation
joyboy copied to clipboard

Implement snip-6 for SocialPay account contract

Open maciejka opened this issue 1 year ago • 8 comments

OD Hack

This issue is part of ODHack 4.0:

  • description - https://x.com/OnlyDust_com/status/1791035111992934563
  • guidelines - https://onlydust.notion.site/ODHack-Common-Guidelines-Project-leads-5e21836f85ad493f9ca429770af0ad40

Task

Implement snip-6 for SocialPay account:

  • account contract is here: https://github.com/keep-starknet-strange/joyboy/blob/main/onchain/src/social/account.cairo
  • it should use bip-340 verification for signature verification: https://github.com/keep-starknet-strange/joyboy/blob/af4ff42f0036739a196a498da5b03933fc3ae16f/onchain/src/bip340.cairo#L149

References

  • https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-6.md

Communication

https://t.me/JoyboyStarknet/949

May the Joy be with you!

maciejka avatar May 22 '24 18:05 maciejka

Can I hop on this

No-bodyq avatar May 22 '24 18:05 No-bodyq

Hi @maciejka I'm want to take the task of implementing SNIP-6 for the SocialPay account contract. I've reviewed the contract code and I'm confident in my ability to integrate the bip-340 verification for signature verification efficiently. Estimated Delivery Timeline: Start Date: May 23, 2024, Completion Date: June 1, 2024

jimenezz22 avatar May 22 '24 19:05 jimenezz22

Hi, I am Cairo programmer and have a good idea how this would work. I would like to work on this.

VictoriaAde avatar May 22 '24 23:05 VictoriaAde

@maciejka kindly assigned Thank you

mubarak23 avatar May 23 '24 08:05 mubarak23

from the implementation of SRC6, i need to register our account interface in SRC5 Supported interface

how do i get the our account contract interface Id @maciejka

mubarak23 avatar May 25 '24 05:05 mubarak23

as part of this implementation, do i need to implement validate and execute function

mubarak23 avatar May 25 '24 06:05 mubarak23

can you point me to good code implementation of SRC5

mubarak23 avatar May 25 '24 06:05 mubarak23

@maciejka does this implementation look similar to what we are going to do on this issue Argent account contract

mubarak23 avatar May 26 '24 12:05 mubarak23