tbtc-website icon indicating copy to clipboard operation
tbtc-website copied to clipboard

Add Korean to the list of enabled locales

Open mhluongo opened this issue 4 years ago • 7 comments

ISO 639-1 language code is ko.

The language is left-to-right. I'm not sure about existing typeface support, but I expect it's more common than eg Mandarin considering the structure of Hangul cc @Gluzman

Blocks #65

mhluongo avatar Jun 30 '20 13:06 mhluongo

Google Font: Noto Sans likely the right choice here.

Gluzman avatar Jul 01 '20 17:07 Gluzman

I am DetoxJuice and I agree with this font!

DetoxJuice avatar Jul 09 '20 23:07 DetoxJuice

Yeah you are! Good to have a speaker sign off, thanks @DetoxJuice!

mhluongo avatar Jul 10 '20 00:07 mhluongo

Hi @mhluongo I'm very new to Github! Is it normal that I don't see korean at tbtc.network/admin? What should I do from here?

DetoxJuice avatar Jul 10 '20 00:07 DetoxJuice

We need a PR that actually add the language to the config. I'll do it when I'm back at my desktop 🙂

mhluongo avatar Jul 10 '20 00:07 mhluongo

SunTzu just helped me out to add "ko", so I believe I can start translating! if otherwise, please advise.

DetoxJuice avatar Jul 10 '20 01:07 DetoxJuice

Go for it!

mhluongo avatar Jul 16 '20 14:07 mhluongo