keep-core icon indicating copy to clipboard operation
keep-core copied to clipboard

Migrate ECDSA tests to Allowlist mode (TIP-092 compliance)

Open lrsaturnino opened this issue 2 months ago • 0 comments

Context

TokenStaking integration tests are failing because external deployment scripts call TokenStaking.approveApplication() which was removed in v1.3.0-dev.16 (TIP-092/TIP-100).

Current State

  • TokenStaking frozen for RandomBeacon/ECDSA (only TACo active)
  • Tests skipped with deprecation warnings (tactical fix from T-009)
  • T-006 dual-mode fixtures implemented and ready

Migration Goal

Migrate all ECDSA integration tests from TokenStaking mode to Allowlist mode.

Timeline

  • Started: 2025-10-23
  • Deadline: 2025-11-06 (2 weeks)
  • Estimated effort: 2-4 weeks total

Migration Approach

Use T-006 dual-mode fixtures with Allowlist mode:

const { walletRegistry, allowlist } = await walletRegistryFixture({ useAllowlist: true })

Affected Test Files

  1. test/WalletRegistry.Authorization.test.ts (50+ TokenStaking calls)
  2. test/WalletRegistry.CustomErrors.test.ts (3 TokenStaking calls)
  3. test/WalletRegistry.Slashing.test.ts (3 TokenStaking calls)
  4. test/WalletRegistry.WalletCreation.test.ts (6 TokenStaking calls)

References

  • T-006 Implementation: solidity/ecdsa/test/fixtures/index.ts
  • T-009 Tactical Fix: memory-bank T-009.md
  • TIP-092: Beta Staker Consolidation
  • TIP-100: TokenStaking sunset timeline

Success Criteria

  • [ ] All affected tests migrated to Allowlist mode
  • [ ] Tests pass with USE_EXTERNAL_DEPLOY=true
  • [ ] Skip blocks removed (tactical fix retired)
  • [ ] Test suite validates production architecture

lrsaturnino avatar Oct 23 '25 17:10 lrsaturnino