keep-core icon indicating copy to clipboard operation
keep-core copied to clipboard

Rename hardhat network from `development` to `local`

Open nkuba opened this issue 3 years ago • 0 comments

As noticed by @dimpar in https://github.com/keep-network/keep-core/pull/3129#discussion_r941277199 we got some naming clashing for development network/environment.

Currently we've got the following networks in hardhat:

  • hardhat (default) - local hardhat node
  • development - local geth node
  • goerli - public test network
  • mainnet - public main network

To use contract packages as dependencies during the development, in the CI we build artifacts and publish them to NPM tagged development. These artifacts can be used as compiled artifacts but we cannot use the addresses to call them, as they were deployed to internal CI's hardhat node during the CI workflow execution.

In the client, we also pull those packages tagged development to build the client with the latest version of contract bindings.

An alternative path is when a developer wants to deploy contracts on their own machine and use the artifacts in the client. The network in hardhat they use is development, to not confuse it with the package the client already expects in https://github.com/keep-network/keep-core/pull/3129 we named this environment local.

I propose that we rename the development network defined in hardhat.config.ts to local. NPM packages will be still published under the development tag.

nkuba avatar Aug 11 '22 14:08 nkuba