keep-core icon indicating copy to clipboard operation
keep-core copied to clipboard

[Do not merge] dApp-friendly contract deployment

Open r-czajkowski opened this issue 3 years ago โ€ข 4 comments

Ref: https://github.com/threshold-network/token-dashboard/issues/136

We need a dApp-friendly version of deployment allowing dashboard developers to build UI components without having to run geth/ganache/hardhat locally and deploying contracts locally.

This PR aims at presenting changes to smart contracts deployed to Sepolia that are used by the dApp development team for day-to-day work. Please do not merge this PR to main branch. Smart contract with the changes presented here are pushed to NPM registry with a tag dapp-development-sepolia.

Main changes:

  • changes the authorizationDecreaseDelay and authorizationDecreaseChangePeriod to 180 seconds instead of 45 days, so we can test the authorization decrease flow faster in the T dapp on testnet.

r-czajkowski avatar Jul 29 '22 12:07 r-czajkowski

Could you change this PR to draft and add a visible info in the description that those changes are not supposed to get merged to main? ~~Also, I was wondering if there's some way to additionally block the merging of this PR via GH settings. I mean something similar to protected branches functionality. From a quick googling I don't see such setting... Marking the PR as draft and explaining that the changes should not go to main will need to be enough then...~~ [EDIT]: Oh, I see now that the CODEOWNERS file is there to protect us from unwanted merges. Good then ๐Ÿ‘ But we could change PR to draft and add info to the description anyway.

michalinacienciala avatar Aug 02 '22 07:08 michalinacienciala

@r-czajkowski, when I tested the deployment of ecdsa contracts from dapp-development branch, I got following error:

ยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยท|ยทยทยทยทยทยทยทยทยทยทยทยทยทยท
 |  WalletRegistryGovernance     ยท     17.088  โ”‚
 ยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยทยท|ยทยทยทยทยทยทยทยทยทยทยทยทยทยท
 |  Wallets                      ยท      0.086  โ”‚
 ยท-------------------------------|-------------ยท

Error in plugin hardhat-contract-sizer: Warning: 1 contracts exceed the size limit for mainnet deployment.

For more info run Hardhat with --show-stack-traces
error Command failed with exit code 1.

This happens both on yarn deploy:test and yarn build.

michalinacienciala avatar Aug 18 '22 11:08 michalinacienciala

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/6786867212 check.

github-actions[bot] avatar Nov 07 '23 15:11 github-actions[bot]

Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/6786867235 check.

github-actions[bot] avatar Nov 07 '23 15:11 github-actions[bot]