keep-core icon indicating copy to clipboard operation
keep-core copied to clipboard

Published 20 hours ago • verified publisher icon keep-network

Visual QA Coverage Pool -- Part: the Second

Open liz-shinn opened this issue 4 years ago • 8 comments

Starting the next round of review here that needed testnet KEEP. Let's get to it... 🚗 🌬️

Browser: Chrome

Deposit Flow

  1. REFRESH REQUIRED TO SHOW BALANCE When making a deposit the dashboard doesn't return me the information until refresh. So I have deposited 3,000 KEEP but my balance is the same and no deposits to show. Upon refresh then the Balance shows. It shows a Success message, however. Is confusing: image

  2. SUCCESS MODAL IS MISSING Post deposit, the dApp does not prompt me with a success modal in the end.

  3. REWARDS RATE For testing with users, showing a ">999%" rewards rate if that's not accurate would be misleading Screen Shot 2021-09-17 at 4 58 37 PM

  4. INPUT FIELD Unexpected quirk of numeric inputs: you can't backspace the 0 and have a cleared input field. Also won't let me insert either a . or a , - I would recommend allowing that. Though I do see that it auto-formats with the ,. Screen Shot 2021-09-17 at 5 53 45 PM

  5. LOADING INDICATOR MISSING When things are loading, we display 0 in some areas. We should present a "loading" spinner or indicator on TVL, Balance and Available to Withdraw instances so we don't scare our users that they have a zero balance or that the pool was liquidated while things are loading. Screen Shot 2021-09-17 at 5 59 25 PM

  6. COV KEEP DOESN'T EQUAL KEEP This may clear up later but currently, the value of KEEP is not close to the value of covKEEP. Right now it appears to be 0. Screen Shot 2021-09-17 at 6 47 44 PM

Withdraw Flow

  1. MAX AMOUNT BUTTON DOESN'T WORK Max amount button doesn't work in the withdrawal flow Screen Shot 2021-09-17 at 6 49 26 PM .

  2. UNCLEAR ERROR MESSAGE FOR INPUT Getting an error message for input when there shouldn't be one. My entered amount matches the amount I have available to withdraw. Screen Shot 2021-09-17 at 6 51 23 PM

  3. WITHDRAW FLOW DOESN'T WORK Withdraw flow doesn't work. Unable to enter an amount of KEEP that works to allow you to proceed with withdraw flow. Screen Shot 2021-09-17 at 6 51 55 PM

liz-shinn avatar Sep 17 '21 13:09 liz-shinn

Deposit Flow

  1. WRONG AMOUNT OF KEEPS IN CONFIRMATION MODAL AFTER SUCCESFUL DEPOSIT

Looks like the amount shown in the confirmation modal shows the amount of covKEEPs that user received instead of KEEPs that user deposited (and also there is wrong title - Claim tokens instead of Deposit)

image

michalsmiarowski avatar Sep 20 '21 08:09 michalsmiarowski

Deposit flow - Success Modal - Chrome

After the Deposit the token amount is shown in covKEEP instead of KEEP. This needs to be changed. image

sashatanase avatar Sep 20 '21 12:09 sashatanase

Success Toast - let's make this auto-dismissable after 5 seconds

sashatanase avatar Sep 20 '21 12:09 sashatanase

Withdraw flow - Chrome

In the withdraw card instead of showing the KEEP amount we are showing covKEEP. Please change to KEEP.

image

sashatanase avatar Sep 20 '21 12:09 sashatanase

Withdraw Flow - Chrome

After the Withdraw action from the withdraw card is triggered in the dialog box the amount is shown correctly in KEEP. image

sashatanase avatar Sep 20 '21 12:09 sashatanase

Claiming tokens error - chrome

Even though the claiming tokens it's triggered immediately there is a token contract error in metamask which keeps me off from claiming the tokens, because in the end the transaction fails.

image

sashatanase avatar Sep 23 '21 13:09 sashatanase

After this transaction fails and this is what we get in the console image

sashatanase avatar Sep 23 '21 13:09 sashatanase

Claim Tokens - Success Modal - Firefox, Chrome

Issue with the token amount - I have had 24,999 KEEP but it says 240,000,999 KEEP

image

sashatanase avatar Sep 23 '21 14:09 sashatanase