keep-core icon indicating copy to clipboard operation
keep-core copied to clipboard

dev-daramir/ dashboard: tBTC falling auction participation page

Open daramir opened this issue 5 years ago • 4 comments

Description

  • LiquidationsPage (the page with events that could lead to liquidation) now captures the GotRedemptionSignature and CourtesyCalled. This means it now captures all event sources, finds the related deposit and shows it's status.
  • This PR also contains an inclusion of yet another page in the Token Dashboard. Which would be the continuation of the liquidation flow, with the possibility to participate in falling price auction and purchase ETH from tBTC.

In my view, this work would greatly improve in the short future with:

  • (In LiquidationsPage), filtering features, such as, actionable events only, special type of event, dates, operators (only mine etc),
  • better styling
  • possibly web alerts for new events in LiquidationsPage (and LiquidateDepositPage)

Credits

For this I heavily relied Rafal C's dashboard work, elishadrion's liquidator repo and https://github.com/keep-network/tbtc.js for purchaseSignerBondsAtAuction functionality: - thank you

Please leave your feedback!

Checklist

  • [X] Fork keep-network/keep-core
  • [X] Clone your fork
  • [X] Describe the change you are intending to undertake in the PR description.

Before marking the PR as ready for review, make sure:

  • [ ] It passes the linter checks (npm run lint) (see Pre-commit to make this automatic).
  • [ ] It passes the continuous integration tests on CircleCI. I don't have access to this CircleCI Org
  • [ ] Your changes have sufficient test coverage (e.g regression tests have been added for bug fixes, unit tests for new features)
  • [X] Commits must be signed.

daramir avatar Sep 01 '20 03:09 daramir

Sample screenshots of how this looks like

On liquidations page.... LiquidationsPage

After clicking "Liquidate" and "View Liquidation" After clicking view liquidation

After a few seconds (it has periodic fetch) or page refresh image

If URL is visited for a deposit not in liquidation image

daramir avatar Sep 01 '20 03:09 daramir

@daramir this is awesome- @liz-shinn @r-czajkowski thoughts on this? Mostly interested in how best to integrate it in the dashboard plan

mhluongo avatar Sep 10 '20 18:09 mhluongo

this looks awesome

benlongstaff avatar Oct 21 '20 14:10 benlongstaff

Hi @benlongstaff,

I have a standalone version coming up while the PR goes through (I'm still actively updating it anyway)

Will let you know when the standalone is publicly available. Just want to get a thumbs up from the team on a few details.

Cheers

On Thu, Oct 22, 2020, 1:58 AM benlongstaff [email protected] wrote:

this looks awesome

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/keep-network/keep-core/pull/2027#issuecomment-713639130, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFVBFJHAGAYQCFVNA4D7ZTSL3ZKPANCNFSM4QRGWB5Q .

daramir avatar Oct 21 '20 22:10 daramir