KeenClient-Java icon indicating copy to clipboard operation
KeenClient-Java copied to clipboard

Swallowing exceptions in client callbacks

Open masojus opened this issue 8 years ago • 0 comments

When we call onSuccess()/onFailure on KeenCallback/KeenDetailedCallback we swallow any exceptions. It probably makes sense to not generate exceptions unless debug mode is turned on, if those exceptions were raised in the SDK, but if the exception was raised in client code, an argument could be made that clients would want to see that exception and fix it.

We should talk a bit more about this and decide what to do here.

masojus avatar May 17 '17 06:05 masojus