svelte-notifications
svelte-notifications copied to clipboard
Add default configs as props of Notifications component (fix #24)
Hello there,
I added the default config as props of Notifications component. I'd like to know if the implementation is okay with you and I can document it then. I fixed the 0 timeout still showing a notification. It now takes the default removeAfter value. I updated the example to be able to unselect a direction value.
The cypress tests are currently failing because of the new ability to unselect a position in the example. We can fix that by either:
- unset the default position
- unselect the default position in the beforeEach method
Hello @usernamus , sorry to ping you 😜 Would you be willing to review the PR or maybe you know other maintainers? About the cyperss test, which option do you prefer that I could implement?
@Ennoriel I'll take a look at this over the weekend
Any updates ?