pacmatic icon indicating copy to clipboard operation
pacmatic copied to clipboard

Change 'n pacnew files found' to 'n pac* files found'.

Open qwerty007 opened this issue 9 years ago • 4 comments

https://bbs.archlinux.org/viewtopic.php?id=193477 '1 pacnew files found' turned out to be a pacsave. Would you care to change 'n pacnew files found' to 'n pac* files found'? pacmatic deals with more than just pacnew files.

qwerty007 avatar Feb 11 '15 01:02 qwerty007

This was my thread! thanks for the up! I just came here to address that! I eventually figured out it was a pacsave as you see, but I still don't understand why I would want to be reminded to address pacsave files on every run -- shouldn't pacsaves hang around until the package is possibly reinstalled and then I can merge/update the configs if there is any change to the syntax?

edit: but I agree, if I am not understanding the purpose of pacasves, it would at least be helpful to know that the file in question may not be a pacnew file

pm0u avatar Feb 11 '15 14:02 pm0u

I still don't understand why I would want to be reminded to address pacsave files on every run

Because pacsaves are not meant to hang around. They are backups. The new package would have overwritten your old config, which was moved to a pacsave. You are supposed to immediately merge/test your config tweaks and delete the pacsave.

Frankly this issue like a silly thing. You have to do the exact same work regardless of whether or not it is a pacsave or pacnew. If anything, pacsaves are more critical because it means your custom config is no longer being used.

keenerd avatar Feb 15 '15 18:02 keenerd

Sorry I guess I'm not totally understanding it. I will get my questions answered elsewhere so this doesn't go off topic.

That aside, pacmatic says there are pacnew files to address and when you say yes, nothing happens. This will occur every time pacmatic is run unless the file is sought out and addressed outside of pacmatic. For me, this proved confusing because pacmatic was telling me there was a pacnew file somewhere when in fact there was not, there was a pacsave file. What I see to be the issue is:

  • pacmatic tells that there is a pacnew file when there may be a pacsave or pacorig file that needs to be addressed
  • if that is the case, and you select yes to address the file through pacmatic, nothing happens.

pm0u avatar Feb 16 '15 18:02 pm0u

@pdizzle @keenerd I stumbled across the same issue. Here is my pull request to clarify the wording: https://github.com/keenerd/pacmatic/pull/28

draptik avatar Oct 31 '15 21:10 draptik