keel
keel copied to clipboard
Missing startupProbe from Deployment
I can not find startupProbe in Deployment after Deployment update. This is the values:
helmProvider:
version: "v3"
service:
enabled: true
debug: true
ingress:
enabled: true
hosts:
-
host: "keel.test.one"
paths:
- /
Same happens for me. I have a deployment with a startupProbe defined and after keel makes a image attribute update, the startupProbe attribute is missing. Tested with keel 0.16.1.
keel 0.16.1 is using a version of the k8s.io/client-go libary that predates the introduction of the startupProbe attribute. v11.0.1-0.20190516230509-ae8359b20417+incompatible https://github.com/keel-hq/keel/blob/0.16.1/go.mod#L110
But keel master (and 0.17.0-rc1) now uses k8s.io/client-go 0.16.10: https://github.com/keel-hq/keel/blob/0.17.0-rc1/go.mod#L11 and I've just confirmed that fixes it. I've not looked too closely at the other changes in 0.17.0-rc1 but I have tested a simple deployment with a quay.io webhook trigger and it worked fine without losing the startupProbe.