la-capitaine-icon-theme
la-capitaine-icon-theme copied to clipboard
keeferrourke
Mathematica Icon
Like to https://github.com/keeferrourke/la-capitaine-icon-theme/pull/507 this still contains way too many unrelated changes. This PR should contain additions /changes for a Mathematica icon only - if you want to contribute icons for multiple applications, make a single PR for every icon. That might not sound straightforward, but is usually the best solution.
I'd suggest you should make yourself familiar with the basics of git if necessary, e.g. using this for reference: https://git-scm.com/docs/gittutorial
Thanks for your valuable suggestion.. I will make different request for each contribution, what should I do now should I revert is back to the Mathematica icons only
@s1-ranjan please run svgcleaner and tidy over all the icons present in the PR. Thanks!
EDIT: see the wiki
@keeferrourke I have used scour and tidy as these were available in my repository, running these tools on all the icons is a tedious job, so I ran this task on the files that I have created.
@s1-ranjan I have one last nit-pick before we merge this in -- the text on the mimetype icons shouldn't be ALL CAPS. Please use lower case Roboto size 9 text... then select the text and convert it to a path.
When this change is made, please run the following, where MYFILE is the name of the file to cleaned up.
svgcleaner MYFILE.svg MYFILE.svg
tidy -q -xml -indent -wrap 0 -m MYFILE.svg
You can install svgcleaner via the Rust tool cargo if its not packaged in your regular distribution repositories.
@keeferrourke I have seen a mime type naming is having all the text in ALL CAPS. i.e. text-x-matlab.svg please have a look at this mimetype.
@s1-ranjan thanks for identifying this, I've filed a new issue and will take some time to improve the consistency of our mimetype icons over the coming few weeks! 🙏
@keeferrourke ALL CAPS issue has been fixed for Mathematica, now it can be merged.
@keeferrourke Should I Close this pull request, as I have few more fixes to push