kedro-plugins icon indicating copy to clipboard operation
kedro-plugins copied to clipboard

FIX(kedro-airflow): grouping with fork

Open sbrugman opened this issue 1 year ago • 3 comments

Description

Fixes a bug in the grouping when multiple groups need to be merged.

Development notes

Discovered after running on new DAGs.

Checklist

  • [X] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • [ ] Updated the documentation to reflect the code changes
  • [ ] Added a description of this change in the relevant RELEASE.md file
  • [ ] Added tests to cover my changes

sbrugman avatar Feb 02 '24 16:02 sbrugman

Tests still failing:

FAILED tests/test_node_grouping.py::test_group_memory_nodes[memory_nodes0-expected_nodes0-expected_dependencies0] - AttributeError: 'NoneType' object has no attribute 'append'

astrojuanlu avatar Feb 02 '24 20:02 astrojuanlu

Hi @sbrugman, do you want to continue working on this PR?

merelcht avatar May 21 '24 11:05 merelcht

Yes, I'll rebase and fix the error.

sbrugman avatar May 28 '24 11:05 sbrugman