kedro-plugins icon indicating copy to clipboard operation
kedro-plugins copied to clipboard

Change kedro-docker e2e tests to use the KEDRO_LOGGING_CONFIG environment variable

Open lrcouto opened this issue 1 year ago • 1 comments

Description

kedro-docker's e2e tests are overriding the logging configurations to simplify assertions. Ideally, the logging configurations should be read through the KEDRO_LOGGING_CONFIG environment variable, containing the path to the actual logging.yml file.

We'd need to find a good way to set this environment variable inside the docker containers used for the tests.

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

One initial idea would be to set it through an ENV argument in the Dockerfile used to create the containers.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

lrcouto avatar Dec 21 '23 14:12 lrcouto

@lrcouto Is this ready to be groomed in Backlog grooming? If so you can add this into "Kedro Framework" using the "Project" and mark it in "Inbox" (On the right panel) image

noklam avatar Jan 26 '24 14:01 noklam