keda icon indicating copy to clipboard operation
keda copied to clipboard

new forgejo scaler

Open cobak78 opened this issue 11 months ago • 6 comments

This PR adds a new forgejo autoscaler with the same characteristics of the github autoscaler. Here is the issue for this feature https://github.com/kedacore/keda/issues/6488

Another important discussions on this topic:

  • The issue on forgejo with the new endpoint needed to make this autoscaler work. https://codeberg.org/forgejo/discussions/issues/241
  • The accepted PR https://codeberg.org/forgejo/forgejo/pulls/6300
  • The modifications on the forgejo runner to work as a scaled job. https://code.forgejo.org/forgejo/runner/pulls/423

Checklist

  • [x] When introducing a new scaler, I agree with the scaling governance policy
  • [x] I have verified that my change is according to the deprecations & breaking changes policy
  • [x] Tests have been added
  • [x] Changelog has been updated and is aligned with our changelog requirements
  • [x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [x] A PR is opened to update the documentation on (repo) (if applicable)
  • [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

cobak78 avatar Jan 22 '25 14:01 cobak78

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar May 20 '25 07:05 JorTurFer

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar May 27 '25 08:05 JorTurFer

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Jun 05 '25 12:06 JorTurFer

added the PR on the doc repository https://github.com/kedacore/keda-docs/pull/1577

cobak78 avatar Jun 05 '25 14:06 cobak78

/run-e2e forgejo Update: You can check the progress here

rickbrouwer avatar Jun 15 '25 15:06 rickbrouwer

gentle ping? anything else you need me to do to merge it?

cobak78 avatar Jun 17 '25 07:06 cobak78

gentle ping? anything else you need me to do to merge it?

Thanks for the ping, just waiting on the remaining approvals. Should be good to go after that :)

rickbrouwer avatar Jul 01 '25 10:07 rickbrouwer

/run-e2e forgejo Update: You can check the progress here

rickbrouwer avatar Aug 27 '25 08:08 rickbrouwer

@cobak78 could you help to fix the conflicts?

SpiritZhou avatar Sep 18 '25 06:09 SpiritZhou

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Sep 22 '25 07:09 JorTurFer

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Sep 22 '25 07:09 JorTurFer

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Sep 22 '25 08:09 JorTurFer

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Sep 22 '25 10:09 JorTurFer

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Sep 22 '25 10:09 JorTurFer

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Sep 22 '25 11:09 JorTurFer

Docs PR needs an update: kedacore/keda-docs#1577

true, mb. Let me update docs

JorTurFer avatar Sep 28 '25 10:09 JorTurFer

Semgrep found 1 invalid-usage-of-modified-variable finding:

Variable scaler is likely modified and later used on error. In some cases this could result in panics due to a nil dereference

semgrep-app[bot] avatar Sep 28 '25 10:09 semgrep-app[bot]

/run-e2e forgejo Update: You can check the progress here

JorTurFer avatar Sep 28 '25 11:09 JorTurFer

PTAL @zroubalik

JorTurFer avatar Sep 28 '25 19:09 JorTurFer