new forgejo scaler
This PR adds a new forgejo autoscaler with the same characteristics of the github autoscaler. Here is the issue for this feature https://github.com/kedacore/keda/issues/6488
Another important discussions on this topic:
- The issue on forgejo with the new endpoint needed to make this autoscaler work. https://codeberg.org/forgejo/discussions/issues/241
- The accepted PR https://codeberg.org/forgejo/forgejo/pulls/6300
- The modifications on the forgejo runner to work as a scaled job. https://code.forgejo.org/forgejo/runner/pulls/423
Checklist
- [x] When introducing a new scaler, I agree with the scaling governance policy
- [x] I have verified that my change is according to the deprecations & breaking changes policy
- [x] Tests have been added
- [x] Changelog has been updated and is aligned with our changelog requirements
- [x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
- [x] A PR is opened to update the documentation on (repo) (if applicable)
- [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
/run-e2e forgejo Update: You can check the progress here
/run-e2e forgejo Update: You can check the progress here
/run-e2e forgejo Update: You can check the progress here
added the PR on the doc repository https://github.com/kedacore/keda-docs/pull/1577
/run-e2e forgejo Update: You can check the progress here
gentle ping? anything else you need me to do to merge it?
gentle ping? anything else you need me to do to merge it?
Thanks for the ping, just waiting on the remaining approvals. Should be good to go after that :)
/run-e2e forgejo Update: You can check the progress here
@cobak78 could you help to fix the conflicts?
/run-e2e forgejo Update: You can check the progress here
/run-e2e forgejo Update: You can check the progress here
/run-e2e forgejo Update: You can check the progress here
/run-e2e forgejo Update: You can check the progress here
/run-e2e forgejo Update: You can check the progress here
/run-e2e forgejo Update: You can check the progress here
Semgrep found 1 invalid-usage-of-modified-variable finding:
Variable scaler is likely modified and later used on error. In some cases this could result in panics due to a nil dereference
/run-e2e forgejo Update: You can check the progress here
PTAL @zroubalik