Feature/splunk observability scaler

[sschimper-splunk]

With this pull request, I would like to add a new custom KEDA scaler that interacts with the Splunk Observability Cloud Platform. It is able to query metrics from Splunk Observability Cloud and scale a deployment according to a predefined target value.

As for now, I do not have the created a pull request to update the Helm chart, becasue I did not think it necessary. However, my knowledge about Helm charts is admittedly limited, and I am happy to fix this in hindsight if that is necessary. Thank you.

Checklist

• [X] When introducing a new scaler, I agree with the scaling governance policy
• [X] I have verified that my change is according to the deprecations & breaking changes policy
• [X] Tests have been added
• [X] Changelog has been updated and is aligned with our changelog requirements
• [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• [x] A PR is opened to update the documentation on (repo) (if applicable) -> https://github.com/kedacore/keda-docs/pull/1477
• [X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to:

• Initial proposal, Fixes #6190
• Pull request containing the documentation on this scaler: #1477

[circa10a]

The only files we should be changing under pkg/ in this PR is scalers/ and scaling/. We should remove the other changes introduced.

[circa10a]

We should probably set this PR to WIP/Draft state

[sschimper-splunk]

Thank you for reviewing, @zroubalik. I will work during the next days on fixing the things pointed out.

[sschimper-splunk]

Hi @zroubalik, thanks for the heads-up. Unfortunately, I will not be ready for the new release on November 7th, and I ask you to go ahead without this Splunk Observability Scaler. I work towards being ready for the next release after November 7th. Apologies if I slowed things down.

[semgrep-app[bot]]

Semgrep found 1 no-direct-write-to-responsewriter finding:

• pkg/scalers/azure_pipelines_scaler_test.go
  • L345 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

_{Ignore this finding from no-direct-write-to-responsewriter}

[circa10a]

Somehow the diff now shows 4400+ files changed

[zroubalik]

Somehow the diff now shows 4400+ files changed

maybe a wrong rebase?

[sschimper-splunk]

Hi @zroubalik, the reason for this is the following: I wanted to push a "clean" code base with the only files being modified the scaler, scaler test, and e2e test files. I recloned the repo and edited just these files, and pushed all the files.

If this doesn't comply with git standards or caused confusion, I would like to apologise. I must admit that I have not used git and GitHub much collaboratively.

[zroubalik]

@sschimper-splunk unfortuantely it seems that you included much more stuff into your commits, see the number of changed files (4.4k).

I recommend you to copy the files that you added/edited and start with a new branch created from a fresh main.

[sschimper-splunk]

Hi @zroubalik, thank you for your comment. I am very sorry for the confusion I have caused. To resolve the situation, I created a new PR that can be found here: https://github.com/kedacore/keda/pull/6534. The only files changed are the files associated with the new scaler.

[zroubalik]

Closing in favor of https://github.com/kedacore/keda/pull/6534